From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Cc: "Robert P. J. Day" <rpjday@mindspring.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 01/16] vmcp cleanup
Date: Tue, 10 Jul 2007 11:29:36 +0200 [thread overview]
Message-ID: <20070710093041.472843538@de.ibm.com> (raw)
In-Reply-To: 20070710092935.896013926@de.ibm.com
[-- Attachment #1: 001-vmcp-cleanup.diff --]
[-- Type: text/plain, Size: 1178 bytes --]
From: Robert P. J. Day <rpjday@mindspring.com>
No need to use the "&" prefix and, since you're calling nonseekable_open(),
there is no need to use no_llseek().
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
drivers/s390/char/vmcp.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
Index: quilt-2.6/drivers/s390/char/vmcp.c
===================================================================
--- quilt-2.6.orig/drivers/s390/char/vmcp.c
+++ quilt-2.6/drivers/s390/char/vmcp.c
@@ -175,13 +175,12 @@ static long vmcp_ioctl(struct file *file
static const struct file_operations vmcp_fops = {
.owner = THIS_MODULE,
- .open = &vmcp_open,
- .release = &vmcp_release,
- .read = &vmcp_read,
- .llseek = &no_llseek,
- .write = &vmcp_write,
- .unlocked_ioctl = &vmcp_ioctl,
- .compat_ioctl = &vmcp_ioctl
+ .open = vmcp_open,
+ .release = vmcp_release,
+ .read = vmcp_read,
+ .write = vmcp_write,
+ .unlocked_ioctl = vmcp_ioctl,
+ .compat_ioctl = vmcp_ioctl
};
static struct miscdevice vmcp_dev = {
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2007-07-10 9:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 9:29 [patch 00/16] First s390 patchset for 2.6.22+ Martin Schwidefsky
2007-07-10 9:29 ` Martin Schwidefsky [this message]
2007-07-10 9:29 ` [patch 02/16] Fixed comment typo Martin Schwidefsky
2007-07-10 9:29 ` [patch 03/16] sclp: introduce some new interfaces Martin Schwidefsky
2007-07-10 9:29 ` [patch 04/16] sclp: Test facility list before executing a service call Martin Schwidefsky
2007-07-10 9:29 ` [patch 05/16] fixed cdl-format detection Martin Schwidefsky
2007-07-10 9:29 ` [patch 06/16] zcore: Fix __user annotation Martin Schwidefsky
2007-07-10 9:29 ` [patch 07/16] smp: Merge smp_count_cpus() and smp_get_save_areas() Martin Schwidefsky
2007-07-10 9:29 ` [patch 08/16] Bogomips calculation for 64 bit Martin Schwidefsky
2007-07-10 9:29 ` [patch 09/16] Program check in diag 210 under 31 bit Martin Schwidefsky
2007-07-10 9:29 ` [patch 10/16] Remove volatile from atomic_t Martin Schwidefsky
2007-07-10 9:29 ` [patch 11/16] dasd: Avoid compile warnings on !CONFIG_DASD_PROFILE Martin Schwidefsky
2007-07-10 9:29 ` [patch 12/16] system call optimization Martin Schwidefsky
2007-07-10 9:29 ` [patch 13/16] zcrypt: fix request timeout handling Martin Schwidefsky
2007-07-10 9:29 ` [patch 14/16] cio: Remove prototype for non-existing function cmf_reset() Martin Schwidefsky
2007-07-10 9:29 ` [patch 15/16] s390: rename CPU_IDLE to S390_CPU_IDLE Martin Schwidefsky
2007-07-10 9:29 ` [patch 16/16] vmlogrdr function annotation Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070710093041.472843538@de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox