Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets

Duane Griffin
2007-07-10T10:23:27Z

On 10/07/07, Satyam Sharma <ssatyam@cse.iitk.ac.in> wrote:
> + /* Avoid taking lock and disabling interrupts unnecessarily */
> + if (unlikely(list_empty(&target_list)))
> + return;

Is the unlikely a good idea here? Not having any targets may be
unusual but it isn't ridiculous. It might even be a sensible default
for distros. My (very limited) understanding of unlikely is that it
could impose a very large penalty in that case and would make a very
marginal difference at best in the common case.

Cheers,
Duane.

--
"I never could learn to drink that blood and call it wine" - Bob Dylan