Re: [PATCH v2 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

Satyam Sharma
2007-07-12T16:46:12Z

Hi,

On Thu, 12 Jul 2007, Keiichi KII wrote:
> Hi Satyam,
>
> > struct netconsole_target {
> > struct list_head list;
> > +#ifdef CONFIG_NETCONSOLE_DYNAMIC
> > + struct config_item item;
> > + int enabled;
> > +#endif
> > struct netpoll np;
> > };
>
> If CONFIG_NETCONSOLE_DYNAMIC is unset, we can't access to the "enabled" member.
> So, the compile errors occur because the following functions make use of
> the above one.

Gargh, yes.

> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
>
> Index: mm/drivers/net/netconsole.c
> ===================================================================
> --- mm.orig/drivers/net/netconsole.c
> +++ mm/drivers/net/netconsole.c
> @@ -94,8 +94,8 @@ struct netconsole_target {
> struct list_head list;
> #ifdef CONFIG_NETCONSOLE_DYNAMIC
> struct config_item item;
> - int enabled;
> #endif
> + int enabled;
> struct netpoll np;
> };

Yup, enabled should be out of CONFIG_NETCONSOLE_DYNAMIC. I'll include this
change in the next version as well.

Thanks,
Satyam