From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756734AbXGKEah (ORCPT ); Wed, 11 Jul 2007 00:30:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751937AbXGKEa1 (ORCPT ); Wed, 11 Jul 2007 00:30:27 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:19254 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbXGKEaZ (ORCPT ); Wed, 11 Jul 2007 00:30:25 -0400 Date: Tue, 10 Jul 2007 21:29:48 -0700 From: Joel Becker To: Satyam Sharma Cc: Duane Griffin , Linux Kernel Mailing List , Matt Mackall , Keiichi Kii , Netdev , Stephen Hemminger , Andrew Morton , David Miller Subject: Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets Message-ID: <20070711042948.GS1011@tasint.org> Mail-Followup-To: Satyam Sharma , Duane Griffin , Linux Kernel Mailing List , Matt Mackall , Keiichi Kii , Netdev , Stephen Hemminger , Andrew Morton , David Miller References: <20070710091920.23907.96483.sendpatchset@cselinux1.cse.iitk.ac.in> <20070710092001.23907.39876.sendpatchset@cselinux1.cse.iitk.ac.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.13 (2006-08-11) X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote: > Hmm, I put it in there because I expected that the user must have had > at least one target configured (added to target_list) if he's got the > module loaded/built-in (and netconsole registered), which is when this > function would be triggered anyway. Loading the module won't happen without a config, but there's no requirement that a built-in netconsole has a kernel command-line argument. I always build netconsole for my kernels. Sure, I usually do it as a module, but if I build a monolithic kernel I compile it in. That doesn't mean I always have a server, let alone a netconsole= option :-) Joel -- "When choosing between two evils, I always like to try the one I've never tried before." - Mae West Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127