From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@infradead.org>,
Hugh Dickins <hugh@veritas.com>, Jes Sorensen <jes@sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: recheck lock rlim after f_op->mmap() method
Date: Wed, 11 Jul 2007 11:14:37 +0100 [thread overview]
Message-ID: <20070711101437.GA21735@infradead.org> (raw)
In-Reply-To: <20070711101245.GA18770@dnb.sw.ru>
On Wed, Jul 11, 2007 at 02:12:45PM +0400, Dmitry Monakhov wrote:
> > > Or would this simpler patch be the right one? I suspect the
> > > mspec driver only says VM_LOCKED because of a deep-seated but
> > > irrational fear that its pages might fall into reclaim.
> >
> > Looks good. We probably should add a debug check to do_mmap_pgoff
> > so that ->mmap methods don't change flags that are not for drivers.
> As result fglrx totally goes crazy, because it change vm_flags
> even from ->nopage() calback :)
Well, everyone with half a brain knows that fglrx is not just legally
problematic but an utter piece of junk. We should add more debug checks
to stop it from doing such stupid things. And yes, chaning flags from
->nopage() does not just deserve a warning but a panic.
next prev parent reply other threads:[~2007-07-11 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 18:49 [patch] mm: recheck lock rlim after f_op->mmap() method Dmitry Monakhov
2007-07-10 17:27 ` Hugh Dickins
2007-07-10 17:53 ` Dmitry Monakhov
2007-07-10 19:48 ` Hugh Dickins
2007-07-11 8:39 ` Jes Sorensen
2007-07-11 18:24 ` Hugh Dickins
2007-07-11 9:32 ` Christoph Hellwig
2007-07-11 10:12 ` Dmitry Monakhov
2007-07-11 10:14 ` Christoph Hellwig [this message]
2007-07-11 18:03 ` Hugh Dickins
2007-07-13 9:53 ` Christoph Hellwig
2007-07-13 8:13 ` Andrew Morton
2007-07-13 13:02 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711101437.GA21735@infradead.org \
--to=hch@infradead.org \
--cc=hugh@veritas.com \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox