From: Andrew Morton <akpm@linux-foundation.org>
To: Roland McGrath <roland@redhat.com>
Cc: Jason Wessel <jason.wessel@windriver.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO
Date: Wed, 11 Jul 2007 16:03:35 -0700 [thread overview]
Message-ID: <20070711160335.8705f742.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070711224327.9B0ED4D0555@magilla.localdomain>
On Wed, 11 Jul 2007 15:43:27 -0700 (PDT)
Roland McGrath <roland@redhat.com> wrote:
> > The -gdwarf2 had a specific reason.
>
> I have no objection to it.
>
OK, thanks. So I ended up with the below as a probably-2.6.23 thing:
From: Roland McGrath <roland@redhat.com>
The assembler for a while now supports -gdwarf to generate source line info
just like the C compiler does. Source-level assembly debugging sounds like an
oxymoron, but it is handy to be able to see the right source file and read its
comments rather than just the disassembly. This patch enables -gdwarf for
assembly files when CONFIG_DEBUG_INFO=y and the assembler supports the option.
Signed-off-by: Roland McGrath <roland@redhat.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
Makefile | 1 +
1 files changed, 1 insertion(+)
diff -puN Makefile~pass-g-to-assembler-under-config_debug_info Makefile
--- a/Makefile~pass-g-to-assembler-under-config_debug_info
+++ a/Makefile
@@ -498,6 +498,7 @@ endif
ifdef CONFIG_DEBUG_INFO
CFLAGS += -g
+AFLAGS += $(call as-option, -gdwarf)
endif
# Force gcc to behave correct even for buggy distributions
_
If there are problems it'll most likely be with oddball architectures
running older compilers, I guess. If something blows up we might need to
make this an arch/foo/Makefile thing.
next prev parent reply other threads:[~2007-07-11 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 18:53 [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO Roland McGrath
2007-07-11 21:09 ` Andrew Morton
2007-07-11 21:30 ` Roland McGrath
2007-07-11 22:37 ` Jason Wessel
2007-07-11 22:43 ` Roland McGrath
2007-07-11 23:03 ` Andrew Morton [this message]
2007-07-11 23:07 ` Roland McGrath
2007-07-11 23:15 ` Andreas Schwab
2007-07-11 23:19 ` Roland McGrath
2007-07-11 23:27 ` Andreas Schwab
2007-07-11 23:40 ` Linus Torvalds
2007-07-11 23:53 ` Andrew Morton
2007-07-12 8:23 ` Jan Engelhardt
2007-07-14 1:08 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711160335.8705f742.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jason.wessel@windriver.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox