From: Andrew Morton <akpm@linux-foundation.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: tytso@mit.edu, "linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rocket: Fix mutex locking compile warning
Date: Wed, 11 Jul 2007 18:27:21 -0700 [thread overview]
Message-ID: <20070711182721.0c0e2235.akpm@linux-foundation.org> (raw)
In-Reply-To: <200707120156.32795.mb@bu3sch.de>
On Thu, 12 Jul 2007 01:56:32 +0200
Michael Buesch <mb@bu3sch.de> wrote:
> This fixes
>
> drivers/char/rocket.c: In function ‘rp_write’:
> drivers/char/rocket.c:1705: warning: ignoring return value of ‘mutex_lock_interruptible’, declared with attribute warn_unused_result
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> Index: bu3sch-wireless-dev/drivers/char/rocket.c
> ===================================================================
> --- bu3sch-wireless-dev.orig/drivers/char/rocket.c 2007-05-18 18:09:48.000000000 +0200
> +++ bu3sch-wireless-dev/drivers/char/rocket.c 2007-07-12 01:52:44.000000000 +0200
> @@ -1702,7 +1702,8 @@ static int rp_write(struct tty_struct *t
> if (count <= 0 || rocket_paranoia_check(info, "rp_write"))
> return 0;
>
> - mutex_lock_interruptible(&info->write_mtx);
> + if (mutex_lock_interruptible(&info->write_mtx))
> + return -ERESTARTSYS;
>
> #ifdef ROCKET_DEBUG_WRITE
> printk(KERN_INFO "rp_write %d chars...", count);
>
Thanks, I already have this queued as
rocketc-fix-unchecked-mutex_lock_interruptible.patch
prev parent reply other threads:[~2007-07-12 1:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 23:56 [PATCH] rocket: Fix mutex locking compile warning Michael Buesch
2007-07-12 1:27 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711182721.0c0e2235.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox