Re: [PATCH 2/2] vsprintf.c: optimizing, part 2: base 10 conversion speedup, v2

Re: [PATCH 2/2] vsprintf.c: optimizing, part 2: base 10 conversion speedup, v2

[Andrew Morton]

On Thu, 5 Jul 2007 12:51:52 +0200
Denis Vlasenko <vda.linux@googlemail.com> wrote:

> Using code from
> 
> http://www.cs.uiowa.edu/~jones/bcd/decimal.html
> (with permission from the author, Douglas W. Jones)

Neither of your patches had signed-off-by:s.  Would prefer that they were
included please, given that we're adding stuff from someone's website.

Re: [PATCH 2/2] vsprintf.c: optimizing, part 2: base 10 conversion speedup, v2

[Douglas W. Jones]

On Jul 5, 2007, at 4:34 PM, Andrew Morton wrote:

> On Thu, 5 Jul 2007 12:51:52 +0200
> Denis Vlasenko <vda.linux@googlemail.com> wrote:
>
>> Using code from
>>
>> http://www.cs.uiowa.edu/~jones/bcd/decimal.html
>> (with permission from the author, Douglas W. Jones)
>
> Neither of your patches had signed-off-by:s.  Would prefer that  
> they were
> included please, given that we're adding stuff from someone's website.

The material on my website was somewhere between pseudocode and
code.  The web site is tutorial in nature, and what Vlasenko did
is follow my tutorial and adapt a working chunk of code from the
many code snippets in the tutorial.

If a signoff from me is required, someone will need to tell me how,
since I have no experience with the protocols for Linux code
development.  I am entirely content with the current form of credit
given to me in the code (a comment with a pointer to my web site).

Frankly, I remain a bit surprise that my work has significant payoff
on a Pentium.  I was motivated by the problems of doing fast binary
to ASCII decimal conversion on a brain-dead little microcontroller
with an 8-bit ALU.

		Doug Jones
		jones@cs.uiowa.edu

Re: [PATCH 2/2] vsprintf.c: optimizing, part 2: base 10 conversion speedup, v2

[Jesper Juhl]

On 06/07/07, Douglas W. Jones <jones@cs.uiowa.edu> wrote:
>
> On Jul 5, 2007, at 4:34 PM, Andrew Morton wrote:
>
> > On Thu, 5 Jul 2007 12:51:52 +0200
> > Denis Vlasenko <vda.linux@googlemail.com> wrote:
> >
> >> Using code from
> >>
> >> http://www.cs.uiowa.edu/~jones/bcd/decimal.html
> >> (with permission from the author, Douglas W. Jones)
> >
> > Neither of your patches had signed-off-by:s.  Would prefer that
> > they were
> > included please, given that we're adding stuff from someone's website.
>
> The material on my website was somewhere between pseudocode and
> code.  The web site is tutorial in nature, and what Vlasenko did
> is follow my tutorial and adapt a working chunk of code from the
> many code snippets in the tutorial.
>
> If a signoff from me is required, someone will need to tell me how,
> since I have no experience with the protocols for Linux code
> development.  I am entirely content with the current form of credit
> given to me in the code (a comment with a pointer to my web site).
>
Section 12 of Documentation/SubmittingPatches :

"
12) Sign your work

To improve tracking of who did what, especially with patches that can
percolate to their final resting place in the kernel through several
layers of maintainers, we've introduced a "sign-off" procedure on
patches that are being emailed around.

The sign-off is a simple line at the end of the explanation for the
patch, which certifies that you wrote it or otherwise have the right to
pass it on as a open-source patch.  The rules are pretty simple: if you
can certify the below:

        Developer's Certificate of Origin 1.1

        By making a contribution to this project, I certify that:

        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or

        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or

        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
            it.

        (d) I understand and agree that this project and the contribution
            are public and that a record of the contribution (including all
            personal information I submit with it, including my sign-off) is
            maintained indefinitely and may be redistributed consistent with
            this project or the open source license(s) involved.

then you just add a line saying

        Signed-off-by: Random J Developer <random@developer.example.org>

using your real name (sorry, no pseudonyms or anonymous contributions.)

Some people also put extra tags at the end.  They'll just be ignored for
now, but you can do this to mark internal company procedures or just
point out some special detail about the sign-off.
"


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: [PATCH 2/2] vsprintf.c: optimizing, part 2: base 10 conversion speedup, v2

[Douglas W. Jones]

On Jul 6, 2007, at 10:21 AM, Jesper Juhl wrote:

> then you just add a line saying
>
>        Signed-off-by: Random J Developer  
> <random@developer.example.org>
>
> using your real name (sorry, no pseudonyms or anonymous  
> contributions.)

If it is necessary, then, this line should be put wherever such
signoffs go:

Signed-off-by: Douglas W Jones <jones@cs.uiowa.edu>

This implies my bemused permission to freely use anything developed
from my tutorials on the web, not my endorsement of what was done
with that material.  I say bemused because it seems far fetched to
claim that I have any ownership interest in this material.  The author
of a tutorial text clearly owns the tutorial organization and
presentation of that text, but to claim ownership of the ideas being
taught is strange.

		Doug Jones
		jones@cs.uiowa.edu

Re: [PATCH 2/2] vsprintf.c: optimizing, part 2: base 10 conversion speedup, v2

[Kyle Moffett]

On Jul 06, 2007, at 11:53:40, Douglas W. Jones wrote:
> This implies my bemused permission to freely use anything developed  
> from my tutorials on the web, not my endorsement of what was done  
> with that material.  I say bemused because it seems far fetched to  
> claim that I have any ownership interest in this material.  The  
> author of a tutorial text clearly owns the tutorial organization  
> and presentation of that text, but to claim ownership of the ideas  
> being taught is strange.

The Signed-off-by stuff is sometimes one of those sad but easy little  
things we do to avoid anybody getting stuck in court over patent/ 
copyright later on, and to be able to prove that our GPLed stuff is  
actually ours to GPL.  As it's an implementation of a simple modular  
base-2 math concept I don't see any reason why you need to sign-off;  
the only person who needs to do so is Denis Vlasenko (the person who  
actually wrote the specific copyrighted code).  The real practical  
use is to be able to follow the chain of "I got this from [...]" back  
to its original source, which is especially valuable in the presence  
of scum like SCO (they claimed some of Linus' code as their own).

So I wouldn't worry about it, the only person who really needs to do  
anything is Denis.

Cheers,
Kyle Moffett

Re: [PATCH 2/2] vsprintf.c: optimizing, part 2: base 10 conversion speedup, v2

[Denis Vlasenko]

On Thursday 05 July 2007 21:34, Andrew Morton wrote:
> On Thu, 5 Jul 2007 12:51:52 +0200
> Denis Vlasenko <vda.linux@googlemail.com> wrote:
> 
> > Using code from
> > 
> > http://www.cs.uiowa.edu/~jones/bcd/decimal.html
> > (with permission from the author, Douglas W. Jones)
> 
> Neither of your patches had signed-off-by:s.  Would prefer that they were
> included please, given that we're adding stuff from someone's website.

Sorry. Consider this added to both patches:

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Yes. "Denys" is how Ukrainian bureaucracy insists on spelling my name.
This Signed-off-by thing is official, so here it goes.
Informally please use "Denis".
--
vda

Re: [PATCH 2/2] vsprintf.c: optimizing, part 2: base 10 conversion speedup, v2

[Jan Engelhardt]

On Jul 12 2007 01:26, Denis Vlasenko wrote:
>> Neither of your patches had signed-off-by:s.  Would prefer that they were
>> included please, given that we're adding stuff from someone's website.
>
>Sorry. Consider this added to both patches:
>
>Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
>
>Yes. "Denys" is how Ukrainian bureaucracy insists on spelling my name.
>This Signed-off-by thing is official, so here it goes.
>Informally please use "Denis".

Just spell it out in Cyrillic :)




	Jan
--