Re: [linux-usb-devel] [PATCH 01/02] Sierra Wireless - Add TRU-Install (c) Support

[Oliver Neukum <oliver@neukum.org>]

Am Donnerstag, 12. Juli 2007 schrieb Kevin Lloyd:
> From: Kevin Lloyd <linux@sierrawireless.com>
> 
> This patch adds compatibility with Sierra Wireless' new TRU-Install feature. Future devices that use this feature will not work unless this patch has been applied.

Is this some type of CD-ROM simulation to provide drivers?

> +int sierra_probe(struct usb_interface *iface, const struct usb_device_id *id)
> +{
> +	int result;	
> +	struct usb_device *udev;
> +
> +	udev = usb_get_dev(interface_to_usbdev(iface));
> +
> +	/* Check if in installer mode */
> +	if (id->driver_info == DEVICE_INSTALLER){
> +		dev_dbg("FOUND DEVICE(SW)\n");
> +		result = sierra_set_ms_mode(udev, SWIMS_SET_MODE_Modem);
> +		return 0;

This is not a good idea in the long run. If you don't return an error here,
disconnect() will be called for your driver and will have to deal with
a semiinitialized device.

	Regards
		Oliver