From: Greg KH <greg@kroah.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Randy Dunlap <randy.dunlap@oracle.com>,
James.Smart@Emulex.Com, pcihpd-discuss@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
Andrew Morton <akpm@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [Pcihpd-discuss] [PATCH 26/34] PCI: add pci_try_set_mwi
Date: Wed, 11 Jul 2007 17:37:31 -0700 [thread overview]
Message-ID: <20070712003731.GA8126@kroah.com> (raw)
In-Reply-To: <20070712000149.GX9704@parisc-linux.org>
On Wed, Jul 11, 2007 at 06:01:49PM -0600, Matthew Wilcox wrote:
> On Wed, Jul 11, 2007 at 04:31:40PM -0700, Greg Kroah-Hartman wrote:
> > As suggested by Andrew, add pci_try_set_mwi(), which does not require
> > return-value checking.
>
> Seems like a daft suggestion. What's wrong with just removing the
> __must_check from pci_set_mwi()? Did it find any bugs?
>
> > --- a/drivers/scsi/lpfc/lpfc_init.c
> > +++ b/drivers/scsi/lpfc/lpfc_init.c
> > @@ -1578,10 +1578,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev, const struct pci_device_id *pid)
> > INIT_LIST_HEAD(&phba->fc_nodes);
> >
> > pci_set_master(pdev);
> > - retval = pci_set_mwi(pdev);
> > - if (retval)
> > - dev_printk(KERN_WARNING, &pdev->dev,
> > - "Warning: pci_set_mwi returned %d\n", retval);
> > + pci_try_set_mwi(pdev);
>
> Why remove the warning? Presumably people want to know if pci_set_mwi
> failed.
Randy, this was your change, right?
thanks,
greg k-h
next prev parent reply other threads:[~2007-07-12 0:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11841968053873-git-send-email-gregkh@suse.de>
[not found] ` <11841968092270-git-send-email-gregkh@suse.de>
[not found] ` <11841968133805-git-send-email-gregkh@suse.de>
[not found] ` <11841968172168-git-send-email-gregkh@suse.de>
[not found] ` <11841968221388-git-send-email-gregkh@suse.de>
[not found] ` <11841968302709-git-send-email-gregkh@suse.de>
[not found] ` <11841968341206-git-send-email-gregkh@suse.de>
[not found] ` <11841968561560-git-send-email-gregkh@suse.de>
[not found] ` <11841968591561-git-send-email-gregkh@suse.de>
[not found] ` <11841968633587-git-send-email-gregkh@suse.de>
2007-07-12 0:01 ` [Pcihpd-discuss] [PATCH 26/34] PCI: add pci_try_set_mwi Matthew Wilcox
2007-07-12 0:37 ` Greg KH [this message]
2007-07-12 1:27 ` Randy Dunlap
2007-07-12 3:12 ` Randy Dunlap
2007-07-12 11:29 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070712003731.GA8126@kroah.com \
--to=greg@kroah.com \
--cc=James.Smart@Emulex.Com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox