From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, dipankar@in.ibm.com, josht@linux.vnet.ibm.com,
akpm@linux-foundation.org
Subject: [PATCH] Remove workaround for unimmunized rcu_dereference from mce_log()
Date: Wed, 11 Jul 2007 18:03:08 -0700 [thread overview]
Message-ID: <20070712010308.GA1605@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070712010058.GA30869@linux.vnet.ibm.com>
Remove the rmb() from mce_log(), since the immunized version of
rcu_dereference() makes it unnecessary.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
mce.c | 3 ---
1 file changed, 3 deletions(-)
diff -urpNa -X dontdiff linux-2.6.22-volrcud/arch/x86_64/kernel/mce.c linux-2.6.22-volrcud-mcefix/arch/x86_64/kernel/mce.c
--- linux-2.6.22-volrcud/arch/x86_64/kernel/mce.c 2007-07-08 16:32:17.000000000 -0700
+++ linux-2.6.22-volrcud-mcefix/arch/x86_64/kernel/mce.c 2007-07-11 17:22:06.000000000 -0700
@@ -67,9 +67,6 @@ void mce_log(struct mce *mce)
wmb();
for (;;) {
entry = rcu_dereference(mcelog.next);
- /* The rmb forces the compiler to reload next in each
- iteration */
- rmb();
for (;;) {
/* When the buffer fills up discard new entries. Assume
that the earlier errors are the more interesting. */
next prev parent reply other threads:[~2007-07-12 1:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 1:00 [PATCH] Immunize rcu_dereference() against crazy compiler writers Paul E. McKenney
2007-07-12 1:03 ` Paul E. McKenney [this message]
2007-07-12 14:03 ` Andi Kleen
2007-07-12 14:49 ` Paul E. McKenney
2007-07-12 16:08 ` Josh Triplett
2007-07-17 9:46 ` Andrew Morton
2007-07-17 13:53 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070712010308.GA1605@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=josht@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox