Re: [PATCH] Start to genericize kconfig for use by other projects.

[Adrian Bunk <bunk@stusta.de>]

On Wed, Jul 11, 2007 at 05:18:57PM -0400, Rob Landley wrote:
> On Wednesday 11 July 2007 3:55:21 pm Adrian Bunk wrote:
> > On Wed, Jul 11, 2007 at 03:22:13PM -0400, Rob Landley wrote:
> > >...
> > > --- a/crypto/Makefile	Tue Jul 10 17:51:13 2007 -0700
> > > +++ b/crypto/Makefile	Wed Jul 11 15:07:07 2007 -0400
> > > @@ -50,3 +50,4 @@ obj-$(CONFIG_CRYPTO_CRC32C) += crc32c.o
> > >  obj-$(CONFIG_CRYPTO_CRC32C) += crc32c.o
> > >
> > >  obj-$(CONFIG_CRYPTO_TEST) += tcrypt.o
> > > +obj-m += randint.o
> > >...
> 
> Oops.  Missed a revert.  Sorry 'bout that.
> 
> > If you'd have included a diffstat as described in
> > Documentation/SubmittingPatches section 1 point 14 you might have
> > noticed this yourself...
>...

To avoid misunderstandings: There should have been a smiley.

> (/me goes to read up on diffstat...  Ah, I see, it's a program you install.  I
> thought it was a diff option.  So possibly you could make SubmittingPatches
> longer by mentioning that.)
>...


And we might make SubmittingPatches even longer by additionally 
mentioning
  git-diff --stat


> Rob

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed