From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761454AbXGLXmU (ORCPT ); Thu, 12 Jul 2007 19:42:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757146AbXGLXmI (ORCPT ); Thu, 12 Jul 2007 19:42:08 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:41889 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756416AbXGLXmH (ORCPT ); Thu, 12 Jul 2007 19:42:07 -0400 Date: Thu, 12 Jul 2007 16:41:59 -0700 From: Mike Anderson To: "Eric W. Biederman" Cc: Andrew Morton , Alasdair G Kergon , dm-devel@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [2.6.23 PATCH 14/18] dm: netlink add to core Message-ID: <20070712234159.GC4768@us.ibm.com> References: <20070711210159.GF24114@agk.fab.redhat.com> <20070711143423.36722a41.akpm@linux-foundation.org> <20070712173410.GA2505@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > As for worry about kmallocs do these events happen often? The worst case would most likely be in a dm multipath configuration where you could get a burst of N number events (N being equal to the number of luns times the number of paths that are having an issue). > I would > not expect any of them in the normal course of operation for a system. Yes, the ones that are part of this patch are unexpected events or recovery of the unexpected event. > Worst case you handle extra kmallocs with a library function. > It's not like you are using GFP_ATOMIC. I was using GFP_ATOMIC as I did not want __GFP_IO as in some testing there was a case where heavy file system IO was going on and an injected error event caused the swap device into a temporary queued condition while an event was trying to be sent. I may need to go back and investigate this case on recent kernels as it has been a while since I did the test case. -andmike -- Michael Anderson andmike@us.ibm.com