From: Greg KH <greg@kroah.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Move prototypes for EXPORT_SYMBOL functions to include/linux/pci.h
Date: Thu, 12 Jul 2007 23:05:11 -0700 [thread overview]
Message-ID: <20070713060511.GA23618@kroah.com> (raw)
In-Reply-To: <9A567C91-1DE7-46CC-91A0-58D498B8248B@kernel.crashing.org>
On Fri, Jul 13, 2007 at 12:55:39AM -0500, Kumar Gala wrote:
>
> On Jul 13, 2007, at 12:33 AM, Greg KH wrote:
>
> > On Fri, Jul 13, 2007 at 12:16:29AM -0500, Kumar Gala wrote:
> >> pci_do_scan_bus() and pci_bus_find_capability() are marked EXPORT_SYMBOL
> >> and thus usable outside of the PCI drive core itself. Make the prototypes
> >> for these functions accessible to everyone.
> >
> > Well, no, I'd like to only have the pci hotplug drivers use them if
> > possible. So until we have proper namespaces on the exported symbols,
> > I'd really like to keep these as-is if possible.
> >
> > Or are you needing these symbols for some code outside of the
> > drivers/pci/ directory tree?
>
> I need pci_bus_find_capability() in arch/powerpc pci code.
>
> I'm using it as a way to tell if we are a PCIe PHB.
Ok, care to export only that function then?
thanks,
greg k-h
next prev parent reply other threads:[~2007-07-13 6:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 5:16 [PATCH] PCI: Move prototypes for EXPORT_SYMBOL functions to include/linux/pci.h Kumar Gala
2007-07-13 5:33 ` Greg KH
2007-07-13 5:55 ` Kumar Gala
2007-07-13 6:05 ` Greg KH [this message]
2007-07-13 6:10 ` Kumar Gala
2007-07-13 6:27 ` Greg KH
2007-07-17 4:27 ` [PATCH] PCI: Move prototypes for pci_bus_find_capability " Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070713060511.GA23618@kroah.com \
--to=greg@kroah.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox