Re: [PATCH][RFC] network splice receive v3

Jens Axboe
2007-07-11T18:27:16Z

On Wed, Jul 11 2007, Joel Becker wrote:
> On Wed, Jul 11, 2007 at 11:19:27AM +0200, Jens Axboe wrote:
> > Subject: [PATCH] splice: don't assume regular pages in splice_to_pipe()
> >
> > Allow caller to pass in a release function, there might be
> > other resources that need releasing as well. Needed for
> > network receive.
> >
> > diff --git a/fs/splice.c b/fs/splice.c
> > index 3160951..4b4b501 100644
> > --- a/fs/splice.c
> > +++ b/fs/splice.c
> > @@ -254,11 +254,16 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe,
> > }
> >
> > while (page_nr < spd_pages)
> > - page_cache_release(spd->pages[page_nr++]);
> > + spd->spd_release(spd, page_nr++);
>
> Rather than requiring the caller set this, shouldn't we just
> allow it? Especially given there is only one non-page user?
>
> while (page_nr < spd_pages)
> - page_cache_release(spd->pages[page_nr++]);
> + if (spd->spd_release)
> + spd->spd_release(spd, page_nr++);
> + else
> + page_cache_release(spd->pages[page_nr++]);

Certainly possible, I think it's cleaner with it always being set
though. If it grows other out-of-splice.c users, then your change may be
a good idea though.

--
Jens Axboe