Re: [PATCH] remove PAGE_SIZE from headers_install

Mike Frysinger
2007-07-14T22:59:46Z

On 7/14/07, Olaf Hering <olaf@aepfle.de> wrote:
> On Sat, Jul 14, H. Peter Anvin wrote:
> > Olaf Hering wrote:
> > > Declare PAGE_SIZE as getpagesize() for userspace.
> > > PAGE_SIZE is used in resource.h and shm.h
> >
> > I would think it would be better to not define it at all. Several
> > architectures already don't have PAGE_SIZE visible to userspace in any way.
>
> i386 has it, so everyone uses it.

not anymore ... it's broken too many other architectures so anything
that matters has switched off of it

> asm/user.h uses it for NBPG, which appears in gdb configure scripts.
> Maybe it doesnt trigger there because the sysconf SC_* macros match.

the sourceware tree (binutils/gdb/etc...) bend over backwards to get a
usable definition so not having NBPG available is fine ... there's one
thing left which needs fixing and i have a patch that i need to commit
for that

> other places where asm/page.h is used:
> util-linux configure scripts, strace, xorg-11, and alot more.
> Have to check if they really need it.

those three packages you quote here i know have been fixed in the
latest versions
-mike