From: Al Viro <viro@ftp.linux.org.uk>
To: David Brownell <david-b@pacbell.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
Subject: Re: [PATCH] minimal fixes for drivers/usb/gadget/m66592-udc.c
Date: Mon, 16 Jul 2007 00:24:10 +0100 [thread overview]
Message-ID: <20070715232410.GH21668@ftp.linux.org.uk> (raw)
In-Reply-To: <200707151618.10688.david-b@pacbell.net>
On Sun, Jul 15, 2007 at 04:18:10PM -0700, David Brownell wrote:
> Re the leaks, in probe() request_irq() isn't cleaned up ... but it
> looked to me like the rest of the allocations did get cleaned up
> afer probe() errors. But remove() does indeed leak the memory you
> highlighted.
Why not make ep0_buf a 16bit field in that struct?
next prev parent reply other threads:[~2007-07-15 23:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 23:07 [PATCH] minimal fixes for drivers/usb/gadget/m66592-udc.c David Brownell
2007-07-15 23:18 ` David Brownell
2007-07-15 23:24 ` Al Viro [this message]
2007-07-16 2:54 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2007-07-15 19:59 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070715232410.GH21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shimoda.yoshihiro@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox