From: Jens Axboe <jens.axboe@oracle.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] splice: fix wrong __splice_from_pipe() usage
Date: Mon, 16 Jul 2007 08:34:36 +0200 [thread overview]
Message-ID: <20070716063435.GG5328@kernel.dk> (raw)
In-Reply-To: <877ip1qj29.fsf@duaron.myhome.or.jp>
On Mon, Jul 16 2007, OGAWA Hirofumi wrote:
> Hi,
>
> I've noticed the nfsd read corruption by recent change. And this patch
> fixes the problem for me, is this right fix?
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
>
> __splice_from_pipe() is updating the sd->pos for the actor, but those
> functions are passing the sd of reader side directory. So, splice
> updates sd->pos twice.
>
> This fixes usage of __splice_from_pipe().
For sendfile() usage, or the nfsd path that uses splice to send?
--
Jens Axboe
next prev parent reply other threads:[~2007-07-16 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 0:38 [PATCH] splice: fix wrong __splice_from_pipe() usage OGAWA Hirofumi
2007-07-16 6:34 ` Jens Axboe [this message]
2007-07-16 10:53 ` OGAWA Hirofumi
2007-07-16 11:15 ` Jens Axboe
2007-07-16 12:35 ` OGAWA Hirofumi
2007-07-16 12:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070716063435.GG5328@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox