Re: [patch 6/7] Add common orderly_poweroff()

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 10 May 2007 16:57:14 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Various pieces of code around the kernel want to be able to trigger an
> orderly poweroff.  This pulls them together into a single
> implementation.
> 
> By default the poweroff command is /sbin/poweroff, but it can be set
> via sysctl: kernel/poweroff_cmd.  This is split at whitespace, so it
> can include command-line arguments.
> 
> This patch replaces four other instances of invoking either "poweroff"
> or "shutdown -h now": one sparc64, two sbus drivers, and acpi thermal
> management.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
> Acked-by: Len Brown <lenb@kernel.org>
> Cc: Chris Wright <chrisw@sous-sol.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Andi Kleen <ak@suse.de>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: David S. Miller <davem@davemloft.net>
> 
> ---
>  arch/sparc64/kernel/power.c     |   40 +-------------------------
>  drivers/acpi/thermal.c          |   24 +---------------
>  drivers/sbus/char/bbc_envctrl.c |    5 +--
>  drivers/sbus/char/envctrl.c     |    7 +---
>  include/linux/reboot.h          |    5 +++
>  include/linux/sysctl.h          |    1 
>  kernel/sys.c                    |   58 +++++++++++++++++++++++++++++++++++++++
>  kernel/sysctl.c                 |   10 ++++++

I'm not sure how this ended up in the x86 tree
(ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/add-common-orderly_poweroff),
but recent changes in arch/sparc64/kernel/power.c have broken it.

Dave, those changes hit mainline without ever having appeared in the
sparc-2.6.git tree, afaict.  If they _had_ appeared there I'd have been
able to tell you that there wasn't any point in changing code which we're
planning on deleting.  Otoh,

    [SPARC64]: Export powerd facilities for external entities.
    
    Besides the existing usage for power-button interrupts, we'll
    want to make use of this code for domain-services where the
    LDOM manager can send reboot requests to the guest node.

make me think that this code isn't deleteable any more.

Ho hum, I will delete the sparc64 hunk and shall hope for the best.  Mainly
to avoid downstream rejects - I suspect this patch needs revisting now.

Andi, your tree is looking pretty stale - I hope it will be updated soon?