public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/10] sysfs: fix error handling in create_files()
Date: Mon, 16 Jul 2007 09:29:52 -0700	[thread overview]
Message-ID: <20070716162952.GB30975@suse.de> (raw)
In-Reply-To: <20070716172945.54e07c3c@gondolin.boeblingen.de.ibm.com>

On Mon, Jul 16, 2007 at 05:29:45PM +0200, Cornelia Huck wrote:
> On Mon, 16 Jul 2007 22:52:30 +0900,
> Akinobu Mita <akinobu.mita@gmail.com> wrote:
> 
> > Current error handling in create_files() attempts to remove
> > all attributes passed by argument by remove_files(). But it should
> > only remove the attributes that have been successfully added.
> 
> While this is certainly cleaner, a question out of curiousity: Does
> this fix any problem you saw? sysfs_hash_and_remove() used to be safe
> on non-existing attributes...

I agree, the existing code should work just fine, are you finding that
it does not for some reason?

thanks,

greg k-h

  parent reply	other threads:[~2007-07-16 16:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-16 13:48 [PATCH 0/10] CPU hotplug error handling fixes Akinobu Mita
2007-07-16 13:50 ` [PATCH 1/10] sysfs: fix kmem_cache_free(NULL) Akinobu Mita
2007-07-16 15:43   ` Greg KH
2007-07-16 16:53     ` Akinobu Mita
2007-07-17  7:04       ` Pekka J Enberg
2007-07-16 13:51 ` [PATCH 2/10] sysdev: add error check in sysdev_register() Akinobu Mita
2007-07-16 15:12   ` Cornelia Huck
2007-07-16 16:18     ` Akinobu Mita
2007-07-16 13:52 ` [PATCH 3/10] sysfs: fix error handling in create_files() Akinobu Mita
2007-07-16 15:29   ` Cornelia Huck
2007-07-16 16:28     ` Akinobu Mita
2007-07-16 16:29     ` Greg KH [this message]
2007-07-17 16:22       ` Akinobu Mita
2007-07-16 13:53 ` [PATCH 4/10] cpu: deliver CPU_UP_CANCELED only to NOTIFY_OKed callbacks with CPU_UP_PREPARE Akinobu Mita
2007-07-17  8:23   ` Gautham R Shenoy
2007-07-17 17:18     ` Akinobu Mita
2007-07-18  6:54       ` Gautham R Shenoy
2007-07-18 16:28         ` Akinobu Mita
2007-07-16 13:54 ` [PATCH 5/10] topology: remove topology_dev_map Akinobu Mita
2007-07-16 13:57 ` [PATCH 6/10] thermal_throttle: fix cpu hotplug error handling Akinobu Mita
2007-07-16 13:58 ` [PATCH 7/10] msr: " Akinobu Mita
2007-07-16 13:58 ` [PATCH 8/10] cpuid: " Akinobu Mita
2007-07-16 14:00 ` [PATCH 9/10] mce: " Akinobu Mita
2007-07-16 14:01 ` [PATCH 10/10] intel_cacheinfo: " Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070716162952.GB30975@suse.de \
    --to=gregkh@suse.de \
    --cc=akinobu.mita@gmail.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox