Re: [PATCH 10/12] add module parameter for users who need more outstanding I/O

Andrew Morton
2007-07-03T04:41:43Z

On Tue, 26 Jun 2007 14:50:12 -0400 "Ed L. Cashin" <ecashin@coraid.com> wrote:

> Add module parameter for users who need more outstanding I/O.
>

why?

I assume that there is some performance benefit to permitting some more
outstanding IO, but that's just a wild guess.

Assuming that the guess is right, some explanation of the effects of
altering this tunable would be appropriate.

> ---
> drivers/block/aoe/aoecmd.c | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 8d6540b..9de0024 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -17,6 +17,11 @@ static int aoe_deadsecs = 60 * 3;
> module_param(aoe_deadsecs, int, 0644);
> MODULE_PARM_DESC(aoe_deadsecs, "After aoe_deadsecs seconds, give up and fail dev.");
>
> +static int aoe_maxout = 16;
> +module_param(aoe_maxout, int, 0644);
> +MODULE_PARM_DESC(aoe_maxout,
> + "Only aoe_maxout outstanding packets for every MAC on eX.Y.");
> +
> static struct sk_buff *
> new_skb(ulong len)
> {
> @@ -967,7 +972,6 @@ aoecmd_cfg_rsp(struct sk_buff *skb)
> struct aoeif *ifp;
> ulong flags, sysminor, aoemajor;
> struct sk_buff *sl;
> - enum { MAXFRAMES = 16 };
> u16 n;
>
> h = aoe_hdr(skb);
> @@ -992,8 +996,8 @@ aoecmd_cfg_rsp(struct sk_buff *skb)
> }
>
> n = be16_to_cpu(ch->bufcnt);
> - if (n > MAXFRAMES) /* keep it reasonable */
> - n = MAXFRAMES;
> + if (n > aoe_maxout) /* keep it reasonable */
> + n = aoe_maxout;
>
> d = aoedev_by_sysminor_m(sysminor);
> if (d == NULL) {
> --
> 1.5.2.1
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/