Re: block/bsg.c

Jeff Garzik
2007-07-17T01:12:43Z

Andrew Morton wrote:
> Yup, but the concern (from Al, iirc) was that someone could change the code
> later on, add a new bug and have that bug hidden by the unneeded
> initialisation.

True.

That's why #gccbug went the safe route, took the cost of extra
instructions, and initialized it to zero.

> uninitialized_var() has the advantage that it generates no code, whereas "=
> 0" often adds instructions. Plus of course it is self-documenting, greppable-for
> and centrally alterable.

Agreed.

Jeff