Re: block/bsg.c

Andrew Morton
2007-07-17T00:54:33Z

On Mon, 16 Jul 2007 20:47:45 -0400 Jeff Garzik <jeff@garzik.org> wrote:

> Andrew Morton wrote:
> > The modern way of shutting up gcc is uninitialized_var().
>
>
> Should I convert my misc-2.6.git#gccbug repository over to this, and
> push upstream?

Opinions differ (a bit) but personally I think the benefit of fixing the
warnings outweighs the risk that these suppressions will later hide a real
bug.

Certainly, using uninitialized_var() is better than open-coding "= 0" all
over the place.

Purists can add a config variable to centrally disable uninitialized_var()
if they want to check on the warnings.

> #gccbug branch is a set of places where I have verified that the
> variable is indeed initialized, even though gcc complains it may not be.
>

Do it!