Re: block/bsg.c

Jeff Garzik
2007-07-17T23:38:09Z

James Bottomley wrote:
> @@ -1052,9 +1054,10 @@ int generic_ide_ioctl(ide_drive_t *drive, struct file *file, struct block_device
> int err, (*setfunc)(ide_drive_t *, int);
> u8 *val;
>
> - err = scsi_cmd_ioctl(file, bdev->bd_disk->queue, bdev->bd_disk, cmd, p);
> - if (err != -ENOTTY)
> - return err;
> + switch (cmd) {
> + case SG_IO:
> + return scsi_cmd_ioctl(file, bdev->bd_disk->queue, bdev->bd_disk, cmd, p);
> + }
>
> switch (cmd) {
> case HDIO_GET_32BIT: val = &drive->io_32bit; goto read_val;

At that point you might as well use an 'if'.

But overall -- agreed. ACK.

Jeff