Re: block/bsg.c

Andrew Morton
2007-07-17T19:25:39Z

On Tue, 17 Jul 2007 08:38:11 +0200 Jens Axboe <jens.axboe@oracle.com> wrote:

> > In terms of presentation: this code hit the tree as base patch plus what
> > appear to be 20 bugfixes, none of which are really interesting or relevant
> > to mainline. Personally I think it would be nicer if all that out-of-tree
> > development work was cleaned up and the new code goes in as a single hit.
> >
> > This makes it a lot easier to find out "wtf does this code all do". One
> > finds the first commit and reads the changlog. But this algorithm yields:
> >
> > bsg: support for full generic block layer SG v3
> >
> > which is not helpful.
>
> I agree, I did consider rebasing the merging all patches into a single
> commit prior to submission. In retrospect that would have been better,
> the bug fixes commits prior to inclusion is not that interesting.

I'm doing a git-bisect and....

block/bsg.c: In function 'bsg_register_queue':
block/bsg.c:1014: error: 'struct kobject' has no member named 'dentry'

That's easily fixable in config, but it's another reason for doing
that consolidation prior to merging.