Re: block/bsg.c

Andrew Morton
2007-07-17T03:04:32Z

On Mon, 16 Jul 2007 21:47:21 -0400 Jeff Garzik <jeff@garzik.org> wrote:

> hrm. uninitialized_var(x) does not silence the warning, on my compiler:
>
> [jgarzik@pretzel misc-2.6]$ rpm -q gcc
> gcc-4.1.2-13.fc6
>
> @@ -1358,6 +1358,8 @@ udf_load_partition(struct super_block *sb, kernel_lb_addr
> {
> kernel_lb_addr ino;
> + uninitialized_var(ino.partitionReferenceNum);
> +
> if (!UDF_SB_LASTBLOCK(sb))

[erk, wordwrapping!]

> still yields
>
> fs/udf/super.c: In function ‘udf_fill_super’:
> fs/udf/super.c:1359: warning: ‘ino.partitionReferenceNum’ may be used
> uninitialized in this function
>

We use it as

- int foo;
+ int uninitialized_var(foo);

so what you have is effectively

kernel_lb_addr ino;

ino.partitionReferenceNum = ino.partitionReferenceNum;

so it still warns.

Hopefully this will work:

kernel_lb_addr uninitialized_var(ino);