From: Paul Jackson <pj@sgi.com>
To: "Paul (______) Menage" <menage@google.com>
Cc: balbir@linux.vnet.ibm.com, dhaval@linux.vnet.ibm.com,
xemul@sw.ru, linux-kernel@vger.kernel.org,
containers@lists.osdl.org, akpm@linux-foundation.org
Subject: Re: Containers: css_put() dilemma
Date: Tue, 17 Jul 2007 10:23:27 -0700 [thread overview]
Message-ID: <20070717102327.dc402025.pj@sgi.com> (raw)
In-Reply-To: <6599ad830707170849v11fe8cecs6d172cd38d247e09@mail.gmail.com>
> Because as soon as you do the atomic_dec_and_test() on css->refcnt and
> the refcnt hits zero, then theoretically someone other thread (that
> already holds container_mutex) could check that the refcount is zero
> and free the container structure.
Not just theory ... I've debugged crashes from live customer systems
that were basically this race.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2007-07-17 17:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 18:50 Containers: css_put() dilemma Balbir Singh
2007-07-16 19:03 ` Paul (宝瑠) Menage
2007-07-17 2:21 ` Balbir Singh
2007-07-17 2:35 ` Paul (宝瑠) Menage
2007-07-17 7:00 ` Balbir Singh
2007-07-17 7:18 ` Paul (宝瑠) Menage
2007-07-17 10:28 ` Balbir Singh
2007-07-17 15:49 ` Paul (宝瑠) Menage
2007-07-17 16:02 ` Dave Hansen
2007-07-17 16:15 ` Paul (宝瑠) Menage
2007-07-17 17:23 ` Paul Jackson [this message]
2007-07-17 17:40 ` Balbir Singh
2007-07-17 17:44 ` Paul (宝瑠) Menage
2007-07-17 17:55 ` Paul Jackson
2007-07-17 17:57 ` Paul (宝瑠) Menage
2007-07-17 18:11 ` Balbir Singh
2007-07-17 18:26 ` Paul (宝瑠) Menage
2007-07-18 4:29 ` Balbir Singh
2007-07-18 5:30 ` Balbir Singh
2007-07-18 5:52 ` Srivatsa Vaddagiri
2007-07-18 23:15 ` Paul Menage
2007-07-19 3:44 ` Balbir Singh
2007-07-18 6:07 ` Paul (宝瑠) Menage
2007-07-17 17:53 ` Paul Jackson
2007-07-17 17:55 ` Paul (宝瑠) Menage
2007-07-17 17:58 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717102327.dc402025.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox