From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755479AbXGQMLD (ORCPT ); Tue, 17 Jul 2007 08:11:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750985AbXGQMKx (ORCPT ); Tue, 17 Jul 2007 08:10:53 -0400 Received: from brick.kernel.dk ([80.160.20.94]:1142 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbXGQMKw (ORCPT ); Tue, 17 Jul 2007 08:10:52 -0400 Date: Tue, 17 Jul 2007 14:10:17 +0200 From: Jens Axboe To: Geert Uytterhoeven Cc: FUJITA Tomonori , Andrew Morton , Linux Kernel Development , linux-scsi@vger.kernel.org Subject: Re: [PATCH] Don't define empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG (was: Re: block/bsg.c) Message-ID: <20070717121017.GS5195@kernel.dk> References: <20070716165706.348f6bbf.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17 2007, Geert Uytterhoeven wrote: > Don't define an empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG. > > It's embedded in struct request_queue, but there we have > > #if defined(CONFIG_BLK_DEV_BSG) > struct bsg_class_device bsg_dev; > #endif > > anyway. Thanks, applied. -- Jens Axboe