From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Cc: Frank Pavlic <fpavlic@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 3/8] qdio: output queue stall on FCP and network devices
Date: Tue, 17 Jul 2007 14:17:50 +0200 [thread overview]
Message-ID: <20070717122239.461337642@de.ibm.com> (raw)
In-Reply-To: 20070717121747.591687140@de.ibm.com
[-- Attachment #1: 002-qdio-stall.diff --]
[-- Type: text/plain, Size: 1221 bytes --]
From: Frank Pavlic <fpavlic@de.ibm.com>
When running QIOASSIST enabled qdio devices in a z/VM environment
the output queue for such devices stall in heavy workload situations.
When SQBS and EQBS instructions returns CCQ=96 qdio does not reissue
the instruction again with the register settings done by millicode
but processed the returned qdio buffer. This is wrong. qdio has to
reissue the instruction once again on CCQ=96, as we already do it
for CCQ=97.
Signed-off-by: Frank Pavlic <fpavlic@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
drivers/s390/cio/qdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: quilt-2.6/drivers/s390/cio/qdio.c
===================================================================
--- quilt-2.6.orig/drivers/s390/cio/qdio.c
+++ quilt-2.6/drivers/s390/cio/qdio.c
@@ -166,9 +166,9 @@ qdio_check_ccq(struct qdio_q *q, unsigne
{
char dbf_text[15];
- if (ccq == 0 || ccq == 32 || ccq == 96)
+ if (ccq == 0 || ccq == 32)
return 0;
- if (ccq == 97)
+ if (ccq == 96 || ccq == 97)
return 1;
/*notify devices immediately*/
sprintf(dbf_text,"%d", ccq);
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2007-07-17 12:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 12:17 [patch 0/8] s390 update Martin Schwidefsky
2007-07-17 12:17 ` [patch 1/8] Update default configuration Martin Schwidefsky
2007-07-17 12:17 ` [patch 2/8] Fix disassembly of RX_URRD, SI_URD & PC-relative instructions Martin Schwidefsky
2007-07-17 12:17 ` Martin Schwidefsky [this message]
2007-07-17 12:17 ` [patch 4/8] vmcp cleanup Martin Schwidefsky
2007-07-17 12:17 ` [patch 5/8] z/VM unit record device driver Martin Schwidefsky
2007-07-17 12:17 ` [patch 6/8] Simplify stack trace Martin Schwidefsky
2007-07-17 12:17 ` [patch 7/8] cio: Dont print trailing \0 in modalias_show() Martin Schwidefsky
2007-07-17 12:17 ` [patch 8/8] Fix broken logic, SIGA flags must be bitwise ORed Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717122239.461337642@de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=fpavlic@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox