From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Joe Jin <joe.jin@oracle.com>,
bill.irwin@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add nid sanity on alloc_pages_node
Date: Tue, 17 Jul 2007 13:01:18 -0700 [thread overview]
Message-ID: <20070717130118.bc78d31a.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707172044001.5286@blonde.wat.veritas.com>
On Tue, 17 Jul 2007 20:49:25 +0100 (BST) Hugh Dickins <hugh@veritas.com> wrote:
> --- 2.6.22-git9/mm/hugetlb.c 2007-07-17 20:29:33.000000000 +0100
> +++ linux/mm/hugetlb.c 2007-07-17 20:32:51.000000000 +0100
> @@ -107,15 +107,12 @@ static int alloc_fresh_huge_page(void)
> {
> static int prev_nid;
> struct page *page;
> - static DEFINE_SPINLOCK(nid_lock);
> int nid;
>
> - spin_lock(&nid_lock);
> nid = next_node(prev_nid, node_online_map);
> if (nid == MAX_NUMNODES)
> nid = first_node(node_online_map);
> prev_nid = nid;
> - spin_unlock(&nid_lock);
Given that we've now gone and added deliberate-but-we-hope-benign
races into this code, an elaborate comment which explains and justifies
it all is pretty much obligatory, IMO.
next prev parent reply other threads:[~2007-07-17 20:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 2:45 [PATCH] Add nid sanity on alloc_pages_node Joe Jin
2007-07-13 5:18 ` Andrew Morton
2007-07-13 6:40 ` Joe Jin
2007-07-13 6:49 ` Andrew Morton
2007-07-13 6:57 ` Andrew Morton
2007-07-13 8:29 ` Paul Jackson
2007-07-13 8:38 ` Andrew Morton
2007-07-13 8:43 ` Paul Jackson
2007-07-13 8:49 ` Andrew Morton
2007-07-13 8:54 ` Paul Jackson
2007-07-13 12:48 ` Benjamin Herrenschmidt
2007-07-13 8:03 ` Joe Jin
2007-07-13 8:15 ` Andrew Morton
2007-07-13 12:18 ` Joe Jin
2007-07-13 12:42 ` Paul Jackson
2007-07-14 17:40 ` Nish Aravamudan
2007-07-14 18:04 ` Andrew Morton
2007-07-14 20:47 ` Nish Aravamudan
2007-07-13 8:04 ` gurudas pai
2007-07-13 8:19 ` Andrew Morton
2007-07-13 12:37 ` gurudas pai
2007-07-13 8:37 ` Joe Jin
2007-07-13 8:44 ` Andrew Morton
2007-07-17 15:04 ` Hugh Dickins
2007-07-17 16:32 ` Andrew Morton
2007-07-17 17:26 ` Hugh Dickins
2007-07-17 18:58 ` Andrew Morton
2007-07-17 19:49 ` Hugh Dickins
2007-07-17 20:01 ` Andrew Morton [this message]
2007-07-17 20:35 ` Hugh Dickins
2007-07-18 1:40 ` Joe Jin
2007-07-18 4:49 ` Hugh Dickins
2007-07-18 5:45 ` Andrew Morton
2007-07-18 7:34 ` Joe Jin
2007-07-18 6:32 ` Joe Jin
2007-07-18 8:09 ` Joe Jin
2007-07-18 8:35 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717130118.bc78d31a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bill.irwin@oracle.com \
--cc=hugh@veritas.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox