* [PATCH] um_kmalloc() remnants
@ 2007-07-17 7:49 Al Viro
2007-07-17 8:08 ` Pekka Enberg
2007-07-17 16:31 ` Jeff Dike
0 siblings, 2 replies; 4+ messages in thread
From: Al Viro @ 2007-07-17 7:49 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, akpm, jdike
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
arch/um/drivers/pcap_user.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/drivers/pcap_user.c b/arch/um/drivers/pcap_user.c
index 483aa15..1316456 100644
--- a/arch/um/drivers/pcap_user.c
+++ b/arch/um/drivers/pcap_user.c
@@ -53,7 +53,7 @@ static int pcap_open(void *data)
return -EIO;
}
- pri->compiled = um_kmalloc(sizeof(struct bpf_program));
+ pri->compiled = kmalloc(sizeof(struct bpf_program), UM_GFP_KERNEL);
if(pri->compiled == NULL){
printk(UM_KERN_ERR "pcap_open : kmalloc failed\n");
return -ENOMEM;
--
1.5.3.GIT
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] um_kmalloc() remnants
2007-07-17 7:49 [PATCH] um_kmalloc() remnants Al Viro
@ 2007-07-17 8:08 ` Pekka Enberg
2007-07-17 8:10 ` Pekka Enberg
2007-07-17 16:31 ` Jeff Dike
1 sibling, 1 reply; 4+ messages in thread
From: Pekka Enberg @ 2007-07-17 8:08 UTC (permalink / raw)
To: Al Viro; +Cc: torvalds, linux-kernel, akpm, jdike
On 7/17/07, Al Viro <viro@ftp.linux.org.uk> wrote:
> - pri->compiled = um_kmalloc(sizeof(struct bpf_program));
> + pri->compiled = kmalloc(sizeof(struct bpf_program), UM_GFP_KERNEL);
GFP_KERNEL?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] um_kmalloc() remnants
2007-07-17 8:08 ` Pekka Enberg
@ 2007-07-17 8:10 ` Pekka Enberg
0 siblings, 0 replies; 4+ messages in thread
From: Pekka Enberg @ 2007-07-17 8:10 UTC (permalink / raw)
To: Al Viro; +Cc: torvalds, linux-kernel, akpm, jdike
On 7/17/07, Al Viro <viro@ftp.linux.org.uk> wrote:
> > - pri->compiled = um_kmalloc(sizeof(struct bpf_program));
> > + pri->compiled = kmalloc(sizeof(struct bpf_program), UM_GFP_KERNEL);
On 7/17/07, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> GFP_KERNEL?
Uhm, missed this: http://lkml.org/lkml/2007/6/14/374. Sorry for the noise.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] um_kmalloc() remnants
2007-07-17 7:49 [PATCH] um_kmalloc() remnants Al Viro
2007-07-17 8:08 ` Pekka Enberg
@ 2007-07-17 16:31 ` Jeff Dike
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Dike @ 2007-07-17 16:31 UTC (permalink / raw)
To: Al Viro; +Cc: torvalds, linux-kernel, akpm
On Tue, Jul 17, 2007 at 08:49:35AM +0100, Al Viro wrote:
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
ACK.
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-17 16:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-17 7:49 [PATCH] um_kmalloc() remnants Al Viro
2007-07-17 8:08 ` Pekka Enberg
2007-07-17 8:10 ` Pekka Enberg
2007-07-17 16:31 ` Jeff Dike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox