Re: [PATCH] AFS: Fix file locking

Andrew Morton
2007-07-18T00:50:53Z

On Tue, 17 Jul 2007 13:47:32 +0100
David Howells <dhowells@redhat.com> wrote:

> + if (type == AFS_LOCK_READ &&
> + vnode->flags & (1 << AFS_VNODE_READLOCKED)) {

Here we use

vnode->flags & (1 << foo)

> + set_bit(AFS_VNODE_LOCKING, &vnode->flags);

and elsewhere we use set_bit(foo, &vnode->flags) and clear_bit()

This is a bit strange. Does the open-coded bit-test have any performance
benefit on any architecture? Not on x86 at least, afaik.

Please consider converting all that stuff to test_bit() sometime. It sure
would look a lot better.