Re: [PATCH] x86: make SMP locks handling interact properly with CONFIG_DEBUG_RODATA (2nd try)

Jan Beulich
2007-07-18T05:59:35Z

>> void alternatives_smp_module_del(struct module *mod)
>> {
>> struct smp_alt_module *item;
>> - unsigned long flags;
>>
>> if (smp_alt_once || noreplace_smp)
>> return;
>>
>> - spin_lock_irqsave(&smp_alt, flags);
>> + spin_lock(&smp_alt);
>
>Unrelated change? Why? Should probably be separate patch.

Absolutely not: You can't call change_page_attr(), or more precisely
global_flush_tlb(), with interrupts disabled. And since interrupt disabling
is unneeded here afaics, I simply changed the calls instead of inventing
some ugly workaround.

I'll do the other adjustments you asked for, but it'll be only in about three
weeks from now...

Jan