Re: [PATCH] x86: make SMP locks handling interact properly with CONFIG_DEBUG_RODATA (2nd try)

Jeremy Fitzhardinge
2007-07-04T18:09:19Z

Dave Jones wrote:
> On Wed, Jul 04, 2007 at 08:41:39AM -0700, Jeremy Fitzhardinge wrote:
>
> > I'd already posted a patch to remove smp alternatives. I thought it had
> > been merged already, but I guess it's in Andi's queue.
>
> What was the rationale behind that? Given many distros have now
> moved to shipping just an SMP kernel, this seems like a step backwards?
>

No, there's two mechanisms. There's the clobber the lock prefix thing,
which is unaffected. And there's smp_alternatives, which was a more
ambitious mechanism to completely replace instructions in the SMP vs
non-SMP cases, which is completely unused and therefore removed.

J