Re: [PATCH 1/3] drivers/base/core: improve device_add() error handling, fix bugs

[Greg KH <greg@kroah.com>]

On Wed, Jul 18, 2007 at 04:16:10AM -0400, Jeff Garzik wrote:
>  Cornelia Huck wrote:
> > On Wed, 18 Jul 2007 01:53:48 -0400,
> > Jeff Garzik <jeff@garzik.org> wrote:
> >> The following change was checked into 'warnings' branch of
> >> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
> >>
> >> commit 5330916f5a11d8b7def46a6b3e14a831684032f5
> >> Author: Jeff Garzik <jeff@garzik.org>
> >> Date:   Wed Jul 18 01:41:29 2007 -0400
> >>
> >>     drivers/base/core: improve device_add() error handling, fix bugs
> >>         * silence several warnings by handling sysfs_create_link() failure
> >>         * re-order some operations in error handling, to precisely reverse
> >>       the order of operations, i.e. unwind properly.
> >>         Signed-off-by: Jeff Garzik <jeff@garzik.org>
> >>
> >>  drivers/base/core.c |   46 ++++++++++++++++++++++++++++++----------------
> >>  1 file changed, 30 insertions(+), 16 deletions(-)
> > Hm, what about driver-core-check-return-code-of-sysfs_create_link.patch
> > (merged with ...-fix.patch) which has been in -mm for a while?
> 
>  No idea, I didn't check there.   If someone else has a better patch... 
>  great!  Let's merge it :)

It's in my queue.

Or it should be, hm, Cornelia, can you resend it, I seem to have dropped
it :(

thanks,

greg k-h