From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isdn/sc: compile breakage re check_reset()
Date: Wed, 18 Jul 2007 13:15:02 -0700 [thread overview]
Message-ID: <20070718131502.d54477ea.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070717103343.GA25083@localhost.sw.ru>
On Tue, 17 Jul 2007 14:33:43 +0400
Alexey Dobriyan <adobriyan@sw.ru> wrote:
> There is check_reset() -- global function in drivers/isdn/sc/
> There is check_reset -- variable holding module param in aacraid driver.
>
> On allyesconfig they clash with:
>
> LD drivers/built-in.o
> drivers/isdn/built-in.o: In function `check_reset':
> : multiple definition of `check_reset'
> drivers/scsi/built-in.o:(.data+0xe458): first defined here
> ld: Warning: size of symbol `check_reset' changed from 4 in drivers/scsi/built-in.o to 219 in drivers/isdn/built-in.o
> ld: Warning: type of symbol `check_reset' changed from 1 to 2 in drivers/isdn/built-in.o
>
> Rename the former.
yeah, well, I did aacraid-rename-check_reset.patch last month, but scsi
patches are hard to get rid of.
Both patches are needed: check_reset() is a dopey name.
next prev parent reply other threads:[~2007-07-18 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 10:33 [PATCH] isdn/sc: compile breakage re check_reset() Alexey Dobriyan
2007-07-18 20:15 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-17 10:18 Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718131502.d54477ea.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@sw.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox