Re: [PATCH] sysfs: make sysfs_init_inode() static

[Jean Delvare <khali@linux-fr.org>]

On Wed, 18 Jul 2007 14:30:28 +0900, Tejun Heo wrote:
> With sysfs_fill_super() converted to use sysfs_get_inode(), there is
> no user of sysfs_init_inode() outside of fs/sysfs/inode.c.  Make it
> static.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

Looks good.

Acked-by: Jean Delvare <khali@linux-fr.org>

> ---
>  fs/sysfs/inode.c |    2 +-
>  fs/sysfs/sysfs.h |    1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> Index: work/fs/sysfs/inode.c
> ===================================================================
> --- work.orig/fs/sysfs/inode.c
> +++ work/fs/sysfs/inode.c
> @@ -133,7 +133,7 @@ static inline void set_inode_attr(struct
>   */
>  static struct lock_class_key sysfs_inode_imutex_key;
>  
> -void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode)
> +static void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode)
>  {
>  	inode->i_blocks = 0;
>  	inode->i_mapping->a_ops = &sysfs_aops;
> Index: work/fs/sysfs/sysfs.h
> ===================================================================
> --- work.orig/fs/sysfs/sysfs.h
> +++ work/fs/sysfs/sysfs.h
> @@ -71,7 +71,6 @@ extern void sysfs_remove_one(struct sysf
>  extern int sysfs_addrm_finish(struct sysfs_addrm_cxt *acxt);
>  
>  extern void sysfs_delete_inode(struct inode *inode);
> -extern void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode);
>  extern struct inode * sysfs_get_inode(struct sysfs_dirent *sd);
>  extern void sysfs_instantiate(struct dentry *dentry, struct inode *inode);
>  


-- 
Jean Delvare