Re: [PATCH] Check for compound pages in set_page_dirty()

Hugh Dickins
2007-07-18T18:46:19Z

On Wed, 18 Jul 2007, Jens Axboe wrote:
>
> OK, you clearly have more knowledge in that area than I, but I do wish
> that you would have made a note in the code at least to remove things
> like this. It's pretty ugly to have superflous tests like that,
> especially since there was not even a comment saying _why_ you could not
> call set_page_dirty() on a compound page. I see it in the commit text,
> but nobody looking at fs/bio.c or fs/direct-io.c would directly find any
> reference of that.
>
> Could you submit a patch removing the tests?

Okay, I'll do that - once I've reminded myself how to test it and done so!

Hugh