From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761660AbXGRSiS (ORCPT ); Wed, 18 Jul 2007 14:38:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752289AbXGRSiG (ORCPT ); Wed, 18 Jul 2007 14:38:06 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:37550 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751599AbXGRSiF (ORCPT ); Wed, 18 Jul 2007 14:38:05 -0400 Date: Wed, 18 Jul 2007 20:37:27 +0200 From: Adrian Bunk To: Jan Engelhardt Cc: Randy Dunlap , Andrew Morton , Stefan Richter , Linux Kernel Mailing List , Michal Piotrowski Subject: Re: 2.6.22-git* regression: Kconfig prompts without help text Message-ID: <20070718183727.GL3801@stusta.de> References: <469BBDAD.2010908@s5r6.in-berlin.de> <20070718094119.4a26ae03.randy.dunlap@oracle.com> <20070718103456.cf32bf78.randy.dunlap@oracle.com> <469E5629.4020409@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18, 2007 at 08:33:27PM +0200, Jan Engelhardt wrote: > > On Jul 18 2007 11:04, Randy Dunlap wrote: > >> > I have no idea where it came from. (not me) > >> > >> It was akpm: > >> http://linux.bkbits.net:8080/linux-2.6/Documentation/CodingStyle?PAGE=diffs&REV=1.5 > > > > I think that would only make sense if "---help---" is used (like you did) > > instead of the plain "help" string. > > > > In the case of "---help---", it's OK with me not to be indented by 2 more > > spaces. > > === > > kconf also accepts "---help---" besides the usual "help" keyword. > If it is used, I think we can omit the extra spaces, because the > dashes are visible enough a sash. Nope, the majority of "---help---" users don't omit the spaces - and it's more readable with them. > Signed-off-by: Jan Engelhardt > > --- > Documentation/CodingStyle | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > Index: linux-2.6.23/Documentation/CodingStyle > =================================================================== > --- linux-2.6.23.orig/Documentation/CodingStyle > +++ linux-2.6.23/Documentation/CodingStyle > @@ -511,17 +511,16 @@ remember: "indent" is not a fix for bad > > For all of the Kconfig* configuration files throughout the source tree, > the indentation is somewhat different. Lines under a "config" definition > -are indented with one tab, while help text is indented an additional two > -spaces. Example: > +are indented with one tab. Example: > > config AUDIT > bool "Auditing support" > depends on NET > - help > - Enable auditing infrastructure that can be used with another > - kernel subsystem, such as SELinux (which requires this for > - logging of avc messages output). Does not do system-call > - auditing without CONFIG_AUDITSYSCALL. > + ---help--- > + Enable auditing infrastructure that can be used with another > + kernel subsystem, such as SELinux (which requires this for > + logging of avc messages output). Does not do system-call > + auditing without CONFIG_AUDITSYSCALL. > > Features that might still be considered unstable should be defined as > dependent on "EXPERIMENTAL": cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed