From: Jens Axboe <jens.axboe@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Giacomo Catenazzi <cate@cateee.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org
Subject: Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:
Date: Wed, 18 Jul 2007 22:27:41 +0200 [thread overview]
Message-ID: <20070718202740.GN11657@kernel.dk> (raw)
In-Reply-To: <alpine.LFD.0.999.0707181313100.27353@woody.linux-foundation.org>
On Wed, Jul 18 2007, Linus Torvalds wrote:
>
>
> On Wed, 18 Jul 2007, Jens Axboe wrote:
> >
> > I think your analysis is pretty good, however you'd probably want to
> > incorporate that direct in ide_end_request().
>
> Ok, that makes sense too.
>
> And yes, the further cleanup would be:
>
> > Better still would be to make __ide_end_request() take a byte count
> > instead and use end_that_request_chunk(). Then you can get rid of the
> > rounding as well.
>
> and that sounds fine, but is an independent issue and not strictly
> necessary.
Oh yeah, it's just a further improvement, not strictly necessary for
fixing this bug. So it could be done at a later time, all up to Bart...
--
Jens Axboe
next prev parent reply other threads:[~2007-07-18 20:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 19:49 regression: disk error loop (panic?) ide_do_rw_disk-bad: Giacomo Catenazzi
2007-07-17 20:47 ` Michal Piotrowski
2007-07-17 21:20 ` Bartlomiej Zolnierkiewicz
2007-07-17 21:24 ` Linus Torvalds
2007-07-17 22:45 ` Bartlomiej Zolnierkiewicz
2007-07-17 22:38 ` Linus Torvalds
2007-07-17 23:14 ` Bartlomiej Zolnierkiewicz
2007-07-17 23:18 ` Jeff Garzik
2007-07-18 8:09 ` Jens Axboe
2007-07-17 22:57 ` Linus Torvalds
2007-07-18 6:31 ` Giacomo Catenazzi
2007-07-18 19:57 ` Linus Torvalds
2007-07-18 20:08 ` Jens Axboe
2007-07-18 20:11 ` Jens Axboe
2007-07-18 20:14 ` Linus Torvalds
2007-07-18 20:27 ` Jens Axboe [this message]
2007-07-18 22:53 ` Bartlomiej Zolnierkiewicz
2007-07-18 23:20 ` Linus Torvalds
2007-07-19 6:13 ` Jens Axboe
2007-07-19 6:40 ` Giacomo Catenazzi
2007-07-19 6:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718202740.GN11657@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=cate@cateee.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox