From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762205AbXGRU2Q (ORCPT ); Wed, 18 Jul 2007 16:28:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752921AbXGRU2G (ORCPT ); Wed, 18 Jul 2007 16:28:06 -0400 Received: from brick.kernel.dk ([80.160.20.94]:11196 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754599AbXGRU2F (ORCPT ); Wed, 18 Jul 2007 16:28:05 -0400 Date: Wed, 18 Jul 2007 22:27:41 +0200 From: Jens Axboe To: Linus Torvalds Cc: Bartlomiej Zolnierkiewicz , Giacomo Catenazzi , Linux Kernel Mailing List , akpm@linux-foundation.org Subject: Re: regression: disk error loop (panic?) ide_do_rw_disk-bad: Message-ID: <20070718202740.GN11657@kernel.dk> References: <469D1D5E.8050609@cateee.net> <200707172320.12141.bzolnier@gmail.com> <20070718200835.GK11657@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18 2007, Linus Torvalds wrote: > > > On Wed, 18 Jul 2007, Jens Axboe wrote: > > > > I think your analysis is pretty good, however you'd probably want to > > incorporate that direct in ide_end_request(). > > Ok, that makes sense too. > > And yes, the further cleanup would be: > > > Better still would be to make __ide_end_request() take a byte count > > instead and use end_that_request_chunk(). Then you can get rid of the > > rounding as well. > > and that sounds fine, but is an independent issue and not strictly > necessary. Oh yeah, it's just a further improvement, not strictly necessary for fixing this bug. So it could be done at a later time, all up to Bart... -- Jens Axboe