From: Jesper Juhl <jesper.juhl@gmail.com>
To: Corey Minyard <minyard@mvista.com>
Cc: Christian Krafft <krafft@de.ibm.com>,
openipmi-developer@lists.sourceforge.net,
minyard@wf-rch.cirr.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH][IPMI] Fix mem leak in try_init_dmi() code
Date: Thu, 19 Jul 2007 00:57:15 +0200 [thread overview]
Message-ID: <200707190057.16051.jesper.juhl@gmail.com> (raw)
Hi there,
If we ever hit the "default:" case in the switch in try_init_dmi(),
then we'll leak the storage allocated with kzalloc() and assigned
to 'info'.
Note: patch has been compile tested only.
Please consider merging upstream :-)
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
drivers/char/ipmi/ipmi_si_intf.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c
b/drivers/char/ipmi/ipmi_si_intf.c
index 4edfdda..96d2f9e 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2050,6 +2050,7 @@ static __devinit void try_init_dmi(struct dmi_ipmi_data
*ipmi_data)
info->si_type = SI_BT;
break;
default:
+ kfree(info);
return;
}
next reply other threads:[~2007-07-18 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 22:57 Jesper Juhl [this message]
2007-07-19 14:18 ` [PATCH][IPMI] Fix mem leak in try_init_dmi() code Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707190057.16051.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=krafft@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@mvista.com \
--cc=minyard@wf-rch.cirr.com \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox