[2.6 patch] kernel/sched.c: remove 2 unused exports

[2.6 patch] kernel/sched.c: remove 2 unused exports

[Adrian Bunk]

This patch removes the following unused exports:
- EXPORT_SYMBOL(cond_resched_softirq);
- EXPORT_SYMBOL_GPL(__wake_up_sync);

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 kernel/sched.c |    2 --
 1 file changed, 2 deletions(-)

--- linux-2.6.22-rc6-mm1/kernel/sched.c.old	2007-07-12 03:36:55.000000000 +0200
+++ linux-2.6.22-rc6-mm1/kernel/sched.c	2007-07-12 03:37:15.000000000 +0200
@@ -3517,7 +3517,6 @@
 	__wake_up_common(q, mode, nr_exclusive, sync, NULL);
 	spin_unlock_irqrestore(&q->lock, flags);
 }
-EXPORT_SYMBOL_GPL(__wake_up_sync);	/* For internal use only */
 
 void fastcall complete(struct completion *x)
 {
@@ -4453,7 +4452,6 @@
 	}
 	return 0;
 }
-EXPORT_SYMBOL(cond_resched_softirq);
 
 /**
  * yield - yield the current processor to other threads.

Re: [2.6 patch] kernel/sched.c: remove 2 unused exports

[Ingo Molnar]

* Adrian Bunk <bunk@stusta.de> wrote:

> This patch removes the following unused exports:
> - EXPORT_SYMBOL(cond_resched_softirq);
> - EXPORT_SYMBOL_GPL(__wake_up_sync);

these are there for API completeness - their counterparts are exported.

	Ingo

Re: [2.6 patch] kernel/sched.c: remove 2 unused exports

[Adrian Bunk]

On Tue, Jul 17, 2007 at 09:22:33PM +0200, Ingo Molnar wrote:
> 
> * Adrian Bunk <bunk@stusta.de> wrote:
> 
> > This patch removes the following unused exports:
> > - EXPORT_SYMBOL(cond_resched_softirq);
> > - EXPORT_SYMBOL_GPL(__wake_up_sync);
> 
> these are there for API completeness - their counterparts are exported.

Why is something with a comment "For internal use only" part of the API?

> 	Ingo

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] kernel/sched.c: remove 2 unused exports

[Ingo Molnar]

* Adrian Bunk <bunk@stusta.de> wrote:

> On Tue, Jul 17, 2007 at 09:22:33PM +0200, Ingo Molnar wrote:
> > 
> > * Adrian Bunk <bunk@stusta.de> wrote:
> > 
> > > This patch removes the following unused exports:
> > > - EXPORT_SYMBOL(cond_resched_softirq);
> > > - EXPORT_SYMBOL_GPL(__wake_up_sync);
> > 
> > these are there for API completeness - their counterparts are exported.
> 
> Why is something with a comment "For internal use only" part of the 
> API?

yeah, you are right about __wake_up_sync. We'll likely remove sync 
wakeups anyway, and the export is GPL, so it's not a big issue.

The point remains for cond_resched_softirq() though - it's a symmetric 
export to cond_resched()'s export. (I think you should smarten your 
scripts about such 'API family' exports, to avoid false positives.)

	Ingo