From: Ingo Molnar <mingo@elte.hu>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kernel/sched.c: remove 2 unused exports
Date: Thu, 19 Jul 2007 10:44:39 +0200 [thread overview]
Message-ID: <20070719084439.GA22825@elte.hu> (raw)
In-Reply-To: <20070719061051.GO3801@stusta.de>
* Adrian Bunk <bunk@stusta.de> wrote:
> On Tue, Jul 17, 2007 at 09:22:33PM +0200, Ingo Molnar wrote:
> >
> > * Adrian Bunk <bunk@stusta.de> wrote:
> >
> > > This patch removes the following unused exports:
> > > - EXPORT_SYMBOL(cond_resched_softirq);
> > > - EXPORT_SYMBOL_GPL(__wake_up_sync);
> >
> > these are there for API completeness - their counterparts are exported.
>
> Why is something with a comment "For internal use only" part of the
> API?
yeah, you are right about __wake_up_sync. We'll likely remove sync
wakeups anyway, and the export is GPL, so it's not a big issue.
The point remains for cond_resched_softirq() though - it's a symmetric
export to cond_resched()'s export. (I think you should smarten your
scripts about such 'API family' exports, to avoid false positives.)
Ingo
prev parent reply other threads:[~2007-07-19 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 23:52 [2.6 patch] kernel/sched.c: remove 2 unused exports Adrian Bunk
2007-07-17 19:22 ` Ingo Molnar
2007-07-19 6:10 ` Adrian Bunk
2007-07-19 8:44 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719084439.GA22825@elte.hu \
--to=mingo@elte.hu \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox