From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@sgi.com>, torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: kmalloc zero size changes break i386
Date: Thu, 19 Jul 2007 12:01:35 +0200 [thread overview]
Message-ID: <200707191201.35777.ak@suse.de> (raw)
qemu testing and booting test machines with i386 kernels wasn't very successfull
with recent git kernels. I got either BUGs because of failing sysfs initialization
or oopses in kmalloc, but no user land.
I bisected it down to this commit.
To reproduce: try to boot a 386 defconfig kernel, compiled with gcc 4.1, in qemu
-Andi
6cb8f91320d3e720351c21741da795fed580b21b is first bad commit
commit 6cb8f91320d3e720351c21741da795fed580b21b
Author: Christoph Lameter <clameter@sgi.com>
Date: Tue Jul 17 04:03:22 2007 -0700
Slab allocators: consistent ZERO_SIZE_PTR support and NULL result semantics
Define ZERO_OR_NULL_PTR macro to be able to remove the checks from the
allocators. Move ZERO_SIZE_PTR related stuff into slab.h.
Make ZERO_SIZE_PTR work for all slab allocators and get rid of the
WARN_ON_ONCE(size == 0) that is still remaining in SLAB.
Make slub return NULL like the other allocators if a too large memory segmen
t
is requested via __kmalloc.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
next reply other threads:[~2007-07-19 10:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 10:01 Andi Kleen [this message]
2007-07-19 14:08 ` kmalloc zero size changes break i386 Pekka Enberg
2007-07-19 15:17 ` Roland Dreier
2007-07-19 18:11 ` Linus Torvalds
2007-07-19 19:03 ` Pekka Enberg
2007-07-19 19:19 ` Linus Torvalds
2007-07-19 21:03 ` Andi Kleen
2007-07-20 7:12 ` Pekka J Enberg
2007-07-20 7:18 ` Pekka J Enberg
2007-07-20 19:13 ` [PATCH] Fix ZERO_OR_NULL_PTR(ZERO_SIZE_PTR) Roland Dreier
2007-07-19 17:01 ` kmalloc zero size changes break i386 Andi Kleen
2007-07-19 15:57 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707191201.35777.ak@suse.de \
--to=ak@suse.de \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox