Re: [PATCH] Fix memory leak in dlm_add_member() when dlm_node_weight() returns less than zero

David Teigland
2007-07-19T13:24:16Z

On Thu, Jul 19, 2007 at 12:27:43AM +0200, Jesper Juhl wrote:
> Greetings,
>
> There's a memory leak in fs/dlm/member.c::dlm_add_member().
>
> If "dlm_node_weight(ls->ls_name, nodeid)" returns < 0, then
> we'll return without freeing the memory allocated to the (at
> that point yet unused) 'memb'.
> This patch frees the allocated memory in that case and thus
> avoids the leak.

Yep, thanks.

Dave