Re: [PATCH] Warn userspace about including an empty linux/tty.h.

Robert P. J. Day
2007-07-19T22:58:37Z

On Thu, 19 Jul 2007, Andrew Morton wrote:

> On Thu, 19 Jul 2007 07:23:46 -0400 (EDT)
> "Robert P. J. Day" <rpjday@mindspring.com> wrote:
>
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
> > ---
> >
> > what subsystem would something like this belong to?
> >
> >
> > diff --git a/include/linux/tty.h b/include/linux/tty.h
> > index 691a174..fd67da8 100644
> > --- a/include/linux/tty.h
> > +++ b/include/linux/tty.h
> > @@ -5,6 +5,10 @@
> > * 'tty.h' defines some structures used by tty_io.c and some defines.
> > */
> >
> > +#ifndef __KERNEL__
> > +#warning "Please don't include this file from userspace, it's empty."
> > +#endif
> > +
>
> this seems pointless?

it was one of the suggestions that was made. the other was just to
stop exporting tty.h to userspace entirely, but that might break
something in userspace. i really had no strong opinion either way.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================