public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arthur Jones <arthur.jones@qlogic.com>
To: Vasily Tarasov <vtaras@openvz.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>,
	"Luck, Tony" <tony.luck@intel.com>, Jan Kara <jack@ucw.cz>,
	linux-arch@vger.kernel.org
Subject: build fix for x86_64...
Date: Thu, 19 Jul 2007 15:24:11 -0700	[thread overview]
Message-ID: <20070719222411.GO12489@bauxite.pathscale.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

hi vasily,

commit b716395e2b8e450e294537de0c91476ded2f0395
breaks the build for x86_64 (and ia64 too, i guess) if
CONFIG_COMPAT is not turned on.  here is a patch, which
i think is more complete than the previous one posted
to LKML by Doug Chapman (which only fixes ia64, i think).
it lets the build continue, but i have no idea if it's
correct or not..

arthur

[-- Attachment #2: t.patch --]
[-- Type: text/plain, Size: 483 bytes --]

diff --git a/fs/quota.c b/fs/quota.c
index e6577ac..5baeede 100644
--- a/fs/quota.c
+++ b/fs/quota.c
@@ -387,7 +387,7 @@ asmlinkage long sys_quotactl(unsigned int cmd, const char __user *special, qid_t
 	return ret;
 }
 
-#if defined(CONFIG_X86_64) || defined(CONFIG_IA64)
+#if defined(CONFIG_COMPAT) && (defined(CONFIG_X86_64) || defined(CONFIG_IA64))
 /*
  * This code works only for 32 bit quota tools over 64 bit OS (x86_64, ia64)
  * and is necessary due to alignment problems.

             reply	other threads:[~2007-07-19 22:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-19 22:24 Arthur Jones [this message]
2007-07-19 23:09 ` build fix for x86_64 Andi Kleen
2007-07-19 23:54   ` Luck, Tony
2007-07-20  8:32     ` Andi Kleen
2007-07-20 15:55       ` Randy Dunlap
2007-07-20 16:20         ` Luck, Tony
2007-07-20 16:48           ` Matthew Wilcox
2007-07-20 17:03           ` H. Peter Anvin
2007-07-20 17:25             ` Andi Kleen
2007-07-20 17:38               ` H. Peter Anvin
2007-07-20 17:40             ` Andreas Schwab
2007-07-20 17:45               ` H. Peter Anvin
2007-07-20 18:13                 ` Andi Kleen
2007-07-20 19:29                   ` H. Peter Anvin
2007-07-20 22:08                     ` Luck, Tony
2007-07-20 22:34                       ` H. Peter Anvin
2007-07-20 18:27                 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070719222411.GO12489@bauxite.pathscale.com \
    --to=arthur.jones@qlogic.com \
    --cc=ak@suse.de \
    --cc=jack@ucw.cz \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vtaras@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox