Re: kmalloc zero size changes break i386

Pekka Enberg
2007-07-19T19:03:43Z

Linus Torvalds wrote:
> Ok, I think I see it: I think the mm/slab.c conversion of kmalloc(0) is
> totally broken.
>
> The problem? It returns ZERO_SIZE_PTR from __find_general_cachep(), not
> from __kmalloc(). So anythign that uses __find_general_cachep() will get
> an invalid cachep pointer, which was not the point.
>
> Does something like this fix it?

I wondered about that too but I didn't spot any callers that would
actually break. Andi? Roland?

> Christoph, please go over this and see if there are other cases like that.

__do_kmalloc_node probably.

Pekka