From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758829AbXGTGYR (ORCPT ); Fri, 20 Jul 2007 02:24:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754072AbXGTGYG (ORCPT ); Fri, 20 Jul 2007 02:24:06 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:53164 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754005AbXGTGYE (ORCPT ); Fri, 20 Jul 2007 02:24:04 -0400 Date: Thu, 19 Jul 2007 23:23:37 -0700 From: Andrew Morton To: Vitaly Bordug Cc: Jeff Garzik , linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation Message-Id: <20070719232337.184942e0.akpm@linux-foundation.org> In-Reply-To: <20070718233804.24451.22543.stgit@localhost.localdomain> References: <20070718233804.24451.22543.stgit@localhost.localdomain> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug wrote: > > device_bind_driver() error code returning has been fixed. > release() function has been written, so that to free resources > in correct way; the release path is now clean. > > Before the rework, it used to cause > Device 'fixed@100:1' does not have a release() function, it is broken > and must be fixed. > BUG: at drivers/base/core.c:104 device_release() > > Call Trace: > [] kobject_cleanup+0x53/0x7e > [] kobject_release+0x0/0x9 > [] kref_put+0x74/0x81 > [] fixed_mdio_register_device+0x230/0x265 > [] fixed_init+0x1f/0x35 > [] init+0x147/0x2fb > [] schedule_tail+0x36/0x92 > [] child_rip+0xa/0x12 > [] acpi_ds_init_one_object+0x0/0x83 > [] init+0x0/0x2fb > [] child_rip+0x0/0x12 > > > Also changed the notation of the fixed phy definition on > mdio bus to the form of + to make it able to be used by > gianfar and ucc_geth that define phy_id strictly as "%d:%d" and cleaned up > the whitespace issues. > Confused. Does the above refer to the difference between this patch and the previous version, or does it just describe this patch? Hopefully the latter, because the former isn't interesting, long-term. If is _is_ a full standalone description of this patch then it's a bit hard to follow ;) > +config FIXED_MII_1000_FDX > + bool "Emulation for 1000M Fdx fixed PHY behavior" > + depends on FIXED_PHY > + > +config FIXED_MII_AMNT > + int "Number of emulated PHYs to allocate " > + depends on FIXED_PHY > + default "1" > + ---help--- > + Sometimes it is required to have several independent emulated > + PHYs on the bus (in case of multi-eth but phy-less HW for instance). > + This control will have specified number allocated for each fixed > + PHY type enabled. Shouldn't these be runtime options (ie: module parameters)? > > ... > > + * Private information hoder for mii_bus tpyo.