From: William Lee Irwin III <wli@holomorphy.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Adam Litke <agl@us.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>,
Ken Chen <kenchen@google.com>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH] Check for compound pages in set_page_dirty()
Date: Thu, 19 Jul 2007 17:34:45 -0700 [thread overview]
Message-ID: <20070720003445.GN11781@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0707191720300.10512@blonde.wat.veritas.com>
On Thu, Jul 19, 2007 at 06:35:17PM +0100, Hugh Dickins wrote:
> I started from your patch. But it now seems to me a bugfix to remove
> those PageCompound tests, because they're preventing a hugetlb page
> from being marked dirty, when Ken needs it to be marked dirty so
> /proc/sys/vm/drop_caches doesn't drop the data read in by DIO.
> (His original patch went into -stable: would the patch fixing
> this all up need to go into -stable?)
This needs to be done some other way. The dirty bit should not be
significant for pseudofs's with no backing store. The consequences
of making it so are becoming apparent in the IO path, and it
caused performance regressions elsewhere as well. ramfs, for instance,
doesn't require anything of this sort to cope with drop_caches.
-- wli
next prev parent reply other threads:[~2007-07-20 0:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 14:15 [PATCH] Check for compound pages in set_page_dirty() Jens Axboe
2007-07-18 15:40 ` Hugh Dickins
2007-07-18 18:24 ` Jens Axboe
2007-07-18 18:40 ` Jens Axboe
2007-07-18 20:35 ` Hugh Dickins
2007-07-19 6:29 ` Jens Axboe
2007-07-19 8:07 ` Jens Axboe
2007-07-19 17:35 ` Hugh Dickins
2007-07-20 0:34 ` William Lee Irwin III [this message]
2007-07-23 20:54 ` Christoph Lameter
2007-07-26 17:37 ` Hugh Dickins
2007-07-26 17:44 ` Christoph Lameter
2007-07-26 17:59 ` Hugh Dickins
2007-07-26 18:16 ` Christoph Lameter
2007-07-18 18:45 ` Hugh Dickins
2007-07-18 18:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720003445.GN11781@holomorphy.com \
--to=wli@holomorphy.com \
--cc=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=david@gibson.dropbear.id.au \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox