drivers/base/core.c broken for non-CONFIG_HOTPLUG

drivers/base/core.c broken for non-CONFIG_HOTPLUG

[Robert Schwebel]

Kay,

With commit 60a96a59569bab85571d0089682109bd3324e896, you broke
drivers/base/core.c for systems which have not enabled CONFIG_HOTPLUG.

You add and use

	extern const char *kobject_actions[];

but the code in lib/kobject_uevent.c who actually brings in the code is
only compiled when CONFIG_HOTPLUG is enabled.

Please send a fix.

Robert
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

Re: drivers/base/core.c broken for non-CONFIG_HOTPLUG

[Greg KH]

On Fri, Jul 20, 2007 at 09:01:06AM +0200, Robert Schwebel wrote:
> Kay,
> 
> With commit 60a96a59569bab85571d0089682109bd3324e896, you broke
> drivers/base/core.c for systems which have not enabled CONFIG_HOTPLUG.
> 
> You add and use
> 
> 	extern const char *kobject_actions[];
> 
> but the code in lib/kobject_uevent.c who actually brings in the code is
> only compiled when CONFIG_HOTPLUG is enabled.
> 
> Please send a fix.

Already known and reported, see lkml :)

Kay is at GUADEC right now and will provide a patch in a day or so,
unless I beat him to it...

thanks,

greg k-h

Re: drivers/base/core.c broken for non-CONFIG_HOTPLUG

[Andrew Morton]

On Fri, 20 Jul 2007 09:01:06 +0200 Robert Schwebel <r.schwebel@pengutronix.de> wrote:

> You add and use
> 
> 	extern const char *kobject_actions[];

Added it in a .c file, too.  Even checkpatch.pl knows that
was wrong.

Re: drivers/base/core.c broken for non-CONFIG_HOTPLUG

[Kay Sievers]

On Fri, 2007-07-20 at 00:59 -0700, Andrew Morton wrote:
> On Fri, 20 Jul 2007 09:01:06 +0200 Robert Schwebel <r.schwebel@pengutronix.de> wrote:
> 
> > You add and use
> > 
> > 	extern const char *kobject_actions[];
> 
> Added it in a .c file, too.  Even checkpatch.pl knows that
> was wrong.

The kernel is doing that all over the place for global symbols that are
not meant to be used out of a "private" context or where a "private"
header file of a subsystem doesn't exist.

I can change that, if this isn't the way to do it?

Thanks,
Kay

Re: drivers/base/core.c broken for non-CONFIG_HOTPLUG

[Andrew Morton]

On Fri, 20 Jul 2007 14:06:19 +0200 Kay Sievers <kay.sievers@vrfy.org> wrote:

> On Fri, 2007-07-20 at 00:59 -0700, Andrew Morton wrote:
> > On Fri, 20 Jul 2007 09:01:06 +0200 Robert Schwebel <r.schwebel@pengutronix.de> wrote:
> > 
> > > You add and use
> > > 
> > > 	extern const char *kobject_actions[];
> > 
> > Added it in a .c file, too.  Even checkpatch.pl knows that
> > was wrong.
> 
> The kernel is doing that all over the place for global symbols that are
> not meant to be used out of a "private" context or where a "private"
> header file of a subsystem doesn't exist.

Whatever the reason, it's still wrong, because the problem remains: lack of
typechecking between the definition and its users.

It's defensible in one situation: where the definition is in assembly
language.  And even then the symbol can be declared in a header, if only
because a second user may be added.

> I can change that, if this isn't the way to do it?

Please.  Let's find a reasonably-relevant header for it.  If there isn't
one, let's add it; there are quite possibly other things which should be in
that header so choose with care, with that possibility in mind.