* mm/Kconfig MEMORY_HOTPLUG typo ?
@ 2007-07-20 12:23 Gabriel C
2007-07-20 12:30 ` Adrian Bunk
2007-07-20 12:36 ` Paul Mundt
0 siblings, 2 replies; 4+ messages in thread
From: Gabriel C @ 2007-07-20 12:23 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Andrew Morton
Hi,
I'm a bit confused about the following from mm/Kconfig:
..
config MEMORY_HOTPLUG
bool "Allow for memory hot-add"
depends on SPARSEMEM || X86_64_ACPI_NUMA
depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG
depends on (IA64 || X86 || PPC64 || SUPERH)
comment "Memory hotplug is currently incompatible with Software Suspend"
depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND
...
That should be !SOFTWARE_SUSPEND no ?
Regards,
Gabriel C
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mm/Kconfig MEMORY_HOTPLUG typo ?
2007-07-20 12:23 mm/Kconfig MEMORY_HOTPLUG typo ? Gabriel C
@ 2007-07-20 12:30 ` Adrian Bunk
2007-07-20 12:36 ` Paul Mundt
1 sibling, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2007-07-20 12:30 UTC (permalink / raw)
To: Gabriel C; +Cc: Linux Kernel Mailing List, Andrew Morton
On Fri, Jul 20, 2007 at 02:23:48PM +0200, Gabriel C wrote:
> Hi,
>
> I'm a bit confused about the following from mm/Kconfig:
>
> ..
>
> config MEMORY_HOTPLUG
> bool "Allow for memory hot-add"
> depends on SPARSEMEM || X86_64_ACPI_NUMA
> depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG
> depends on (IA64 || X86 || PPC64 || SUPERH)
>
> comment "Memory hotplug is currently incompatible with Software Suspend"
> depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND
>
>
> ...
>
> That should be !SOFTWARE_SUSPEND no ?
No, it's correct.
You should see the comment instead of the option with SOFTWARE_SUSPEND=y.
> Regards,
>
> Gabriel C
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mm/Kconfig MEMORY_HOTPLUG typo ?
2007-07-20 12:23 mm/Kconfig MEMORY_HOTPLUG typo ? Gabriel C
2007-07-20 12:30 ` Adrian Bunk
@ 2007-07-20 12:36 ` Paul Mundt
2007-07-20 13:00 ` Gabriel C
1 sibling, 1 reply; 4+ messages in thread
From: Paul Mundt @ 2007-07-20 12:36 UTC (permalink / raw)
To: Gabriel C; +Cc: Linux Kernel Mailing List, Andrew Morton
On Fri, Jul 20, 2007 at 02:23:48PM +0200, Gabriel C wrote:
> I'm a bit confused about the following from mm/Kconfig:
>
> ..
>
> config MEMORY_HOTPLUG
> bool "Allow for memory hot-add"
> depends on SPARSEMEM || X86_64_ACPI_NUMA
> depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG
> depends on (IA64 || X86 || PPC64 || SUPERH)
>
MEMORY_HOTPLUG is only supported if !SOFTWARE_SUSPEND
> comment "Memory hotplug is currently incompatible with Software Suspend"
> depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND
>
>
> ...
>
> That should be !SOFTWARE_SUSPEND no ?
>
However, we only give the comment that warns about the incompatability
when SOFTWARE_SUSPEND is enabled, otherwise people won't see the option
due to the unmet dependency.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mm/Kconfig MEMORY_HOTPLUG typo ?
2007-07-20 12:36 ` Paul Mundt
@ 2007-07-20 13:00 ` Gabriel C
0 siblings, 0 replies; 4+ messages in thread
From: Gabriel C @ 2007-07-20 13:00 UTC (permalink / raw)
To: Paul Mundt; +Cc: Linux Kernel Mailing List
Paul Mundt wrote:
> On Fri, Jul 20, 2007 at 02:23:48PM +0200, Gabriel C wrote:
>> I'm a bit confused about the following from mm/Kconfig:
>>
>> ..
>>
>> config MEMORY_HOTPLUG
>> bool "Allow for memory hot-add"
>> depends on SPARSEMEM || X86_64_ACPI_NUMA
>> depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG
>> depends on (IA64 || X86 || PPC64 || SUPERH)
>>
> MEMORY_HOTPLUG is only supported if !SOFTWARE_SUSPEND
>
>> comment "Memory hotplug is currently incompatible with Software Suspend"
>> depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND
>>
>>
>> ...
>>
>> That should be !SOFTWARE_SUSPEND no ?
>>
> However, we only give the comment that warns about the incompatability
> when SOFTWARE_SUSPEND is enabled, otherwise people won't see the option
> due to the unmet dependency.
>
I think I got it :)
Thx for the clarification.
Gabriel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-20 13:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-20 12:23 mm/Kconfig MEMORY_HOTPLUG typo ? Gabriel C
2007-07-20 12:30 ` Adrian Bunk
2007-07-20 12:36 ` Paul Mundt
2007-07-20 13:00 ` Gabriel C
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox