From: Andrew Morton <akpm@linux-foundation.org>
To: Konrad Rzeszutek <konrad@darnok.org>
Cc: darnok@68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Inhibit NMI watchdog when Alt-SysRq-T operation is underway.
Date: Fri, 20 Jul 2007 14:06:20 -0700 [thread overview]
Message-ID: <20070720140620.e742a2b9.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070720111823.GA2334@andromeda.dapyr.net>
On Fri, 20 Jul 2007 07:18:23 -0400
Konrad Rzeszutek <konrad@darnok.org> wrote:
> I tested your patch along with mine and found two things out:
>
> 1). Missing this patch (for i386 platform)
>
> diff --git a/arch/i386/kernel/traps.c b/arch/i386/kernel/traps.c
> index 90da057..9f3a7ff 100644
> --- a/arch/i386/kernel/traps.c
> +++ b/arch/i386/kernel/traps.c
> @@ -207,6 +207,7 @@ static void print_trace_address(void *da
> {
> printk("%s [<%08lx>] ", (char *)data, addr);
> print_symbol("%s\n", addr);
> + touch_nmi_watchdog();
> }
ok...
> static struct stacktrace_ops print_trace_ops = {
>
>
> 2). If I run Alt-SysRq-t about 5000 times in a loop, the slow down
> with this change is about 5%. Is this a big issue? (This was
> testing both i686 and x86_64).
>
I'm surprised. I assume this was when it was printing to a high-speed
device? console or netconsole?
I don't think we need to spend too much time optimising sysrq-T performance ;)
prev parent reply other threads:[~2007-07-20 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 14:02 [PATCH] Inhibit NMI watchdog when Alt-SysRq-T operation is underway Konrad Rzeszutek
2007-07-09 15:53 ` darnok
2007-07-13 23:45 ` Andrew Morton
2007-07-20 11:18 ` Konrad Rzeszutek
2007-07-20 21:06 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720140620.e742a2b9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=darnok@68k.org \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox