From: Greg KH <gregkh@suse.de>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Gabriel C <nix.or.die@googlemail.com>,
Robert Schwebel <r.schwebel@pengutronix.de>,
Jan Engelhardt <jengelh@computergmbh.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kay.sievers@vrfy.org
Subject: Re: kobject link failure
Date: Fri, 20 Jul 2007 08:06:27 -0700 [thread overview]
Message-ID: <20070720150627.GA12822@suse.de> (raw)
In-Reply-To: <20070720135813.0e416b2b@gondolin.boeblingen.de.ibm.com>
On Fri, Jul 20, 2007 at 01:58:13PM +0200, Cornelia Huck wrote:
> On Fri, 20 Jul 2007 11:32:21 +0200,
> Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>
> > Hm, this would be an interface change (the uevent attribute used to
> > exist even for !CONFIG_HOTPLUG, it just triggered nothing). How about
> > moving kobject_actions[] out of the #ifdef (maybe next to
> > kobject_action)?
>
> Leaving kobject_actions[] in kobject_uevent.c, but putting it outside
> the #ifdef looks indeed like the best solution to me. This way, we
> avoid adding #ifdef CONFIG_HOTPLUG into core.c, when all other
> functions called do not need such a thing.
Yeah, this is much nicer and smaller, thanks. I'll throw away my patch
and use this one instead.
Can someone verify that it works properly for them please?
thanks,
greg k-h
next prev parent reply other threads:[~2007-07-20 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 18:03 kobject link failure Jan Engelhardt
2007-07-19 18:11 ` Gabriel C
2007-07-19 19:19 ` Greg KH
2007-07-20 8:00 ` Greg KH
2007-07-20 9:32 ` Cornelia Huck
2007-07-20 11:58 ` Cornelia Huck
2007-07-20 15:06 ` Greg KH [this message]
2007-07-20 16:02 ` Jan Engelhardt
2007-07-19 19:18 ` Greg KH
2007-07-19 20:00 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720150627.GA12822@suse.de \
--to=gregkh@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=jengelh@computergmbh.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nix.or.die@googlemail.com \
--cc=r.schwebel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox