From: Matthew Wilcox <matthew@wil.cx>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ralf Baechle <ralf@linux-mips.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>
Date: Fri, 20 Jul 2007 11:50:50 -0600 [thread overview]
Message-ID: <20070720175050.GI14791@parisc-linux.org> (raw)
In-Reply-To: <46A0F453.60005@ru.mvista.com>
On Fri, Jul 20, 2007 at 09:43:47PM +0400, Sergei Shtylyov wrote:
> Hello Christoph:
>
> >>>+#include <asm/irq.h>
>
> >>These days that should probably be <linux/irq.h>.
>
> >Not at all, linux/irq.h is something entirely different.
>
> Actually, <linux/interrupt.h>
Not for enable/disable_irq. For request_irq, yes.
This is something that should be fixed.
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-07-20 17:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 16:40 [patch 0/3] m68k: -Werror-implicit-function-declaration fallout Geert Uytterhoeven
2007-07-20 16:40 ` [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible Geert Uytterhoeven
2007-07-20 17:47 ` Dmitry Torokhov
2007-07-20 18:35 ` Adrian Bunk
2007-07-20 18:51 ` Dmitry Torokhov
2007-07-20 19:07 ` Adrian Bunk
2007-07-20 19:30 ` Dmitry Torokhov
2007-07-21 8:27 ` Geert Uytterhoeven
2007-07-22 4:22 ` Dmitry Torokhov
2007-07-22 12:51 ` Geert Uytterhoeven
2007-07-24 0:45 ` Dmitry Torokhov
2007-07-20 16:40 ` [patch 2/3] netdev: i82596 Ethernet needs <asm/cacheflush.h> Geert Uytterhoeven
2007-07-24 20:37 ` Jeff Garzik
2007-07-20 16:40 ` [patch 3/3] scsi: wd33c93 needs <asm/irq.h> Geert Uytterhoeven
2007-07-20 16:48 ` James Bottomley
2007-07-20 17:05 ` Geert Uytterhoeven
2007-07-20 17:13 ` Adrian Bunk
2007-07-20 17:31 ` Ralf Baechle
2007-07-20 17:33 ` Christoph Hellwig
2007-07-20 17:43 ` Sergei Shtylyov
2007-07-20 17:50 ` Matthew Wilcox [this message]
2007-07-22 23:34 ` Al Viro
2007-07-20 17:46 ` Ralf Baechle
2007-07-20 17:34 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720175050.GI14791@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox